chromeos: Add VLOG(1)s around renderer-freezing for suspend.

chromeos: Add VLOG(1)s around renderer-freezing for suspend.

Add temporary VLOG(1) messages to renderer-freezing code to
try to track down the cause of a strange crash.

BUG=chromium:648580
Committed: https://crrev.com/04239907e878ce5b4c2f4dfdadb04667f739c433
Cr-Commit-Position: refs/heads/master@{#423750}

[Daniel Erat, 2016-10-06 22:03:19]

derat@chromium.org changed reviewers:
+ chirantan@chromium.org

[Daniel Erat, 2016-10-06 22:05:37]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 22:06:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Chirantan Ekbote, 2016-10-06 22:35:26]

lgtm

Do we need another change to turn on the vlogs for these files?

[Daniel Erat, 2016-10-06 22:40:12]

derat@chromium.org changed reviewers:
+ llozano@chromium.org

[Daniel Erat, 2016-10-06 22:40:12]

luis, can you let me know if the vtable stuff looks correct here?

[llozano, 2016-10-06 22:55:11]

LKGM from my side.

https://codereview.chromium.org/2395293003/diff/20001/chromeos/dbus/power_man...
File chromeos/dbus/power_manager_client.cc (right):

https://codereview.chromium.org/2395293003/diff/20001/chromeos/dbus/power_man...
chromeos/dbus/power_manager_client.cc:93: VLOG(1) << "vtable is " <<
*reinterpret_cast<uintptr_t*>(delegate.get());
nit: you are not using parenthesis after * like in the other places.

[Daniel Erat, 2016-10-06 23:00:09]

thanks! i'll check whether i'm able to repro the crashes from a portage-built
chrome before submitting this.

https://codereview.chromium.org/2395293003/diff/20001/chromeos/dbus/power_man...
File chromeos/dbus/power_manager_client.cc (right):

https://codereview.chromium.org/2395293003/diff/20001/chromeos/dbus/power_man...
chromeos/dbus/power_manager_client.cc:93: VLOG(1) << "vtable is " <<
*reinterpret_cast<uintptr_t*>(delegate.get());
On 2016/10/06 22:55:11, llozano wrote:
> nit: you are not using parenthesis after * like in the other places.

true. i'll remove them from the other places

[Daniel Erat, 2016-10-06 23:20:06]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 23:20:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 23:53:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 23:53:10]

Dry run: This issue passed the CQ dry run.

[Daniel Erat, 2016-10-06 23:59:23]

On 2016/10/06 23:00:09, Daniel Erat wrote:
> thanks! i'll check whether i'm able to repro the crashes from a portage-built
> chrome before submitting this.
> 
>
https://codereview.chromium.org/2395293003/diff/20001/chromeos/dbus/power_man...
> File chromeos/dbus/power_manager_client.cc (right):
> 
>
https://codereview.chromium.org/2395293003/diff/20001/chromeos/dbus/power_man...
> chromeos/dbus/power_manager_client.cc:93: VLOG(1) << "vtable is " <<
> *reinterpret_cast<uintptr_t*>(delegate.get());
> On 2016/10/06 22:55:11, llozano wrote:
> > nit: you are not using parenthesis after * like in the other places.
> 
> true. i'll remove them from the other places

still unable to repro the crash locally, so i guess it's time to commit this.
:-/

[Daniel Erat, 2016-10-06 23:59:30]

The CQ bit was checked by derat@chromium.org

[Daniel Erat, 2016-10-06 23:59:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
chirantan@chromium.org
Link to the patchset: https://codereview.chromium.org/2395293003/#ps40001
(title: "remove extra parens")

[commit-bot: I haz the power, 2016-10-06 23:59:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 00:07:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-07 00:10:47]

Description was changed from

==========
chromeos: Add VLOG(1)s around renderer-freezing for suspend.

Add temporary VLOG(1) messages to renderer-freezing code to
try to track down the cause of a strange crash.

BUG=chromium:648580
==========

to

==========
chromeos: Add VLOG(1)s around renderer-freezing for suspend.

Add temporary VLOG(1) messages to renderer-freezing code to
try to track down the cause of a strange crash.

BUG=chromium:648580

Committed: https://crrev.com/04239907e878ce5b4c2f4dfdadb04667f739c433
Cr-Commit-Position: refs/heads/master@{#423750}
==========

[commit-bot: I haz the power, 2016-10-07 00:10:48]

Patchset 3 (id:??) landed as
https://crrev.com/04239907e878ce5b4c2f4dfdadb04667f739c433
Cr-Commit-Position: refs/heads/master@{#423750}

[Daniel Erat, 2016-10-13 18:11:54]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2413163003/ by derat@chromium.org.

The reason for reverting is: I believe that the underlying bug has been fixed,
so this logging is no longer needed..