Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2395293002: Work around bad line break offset calculation (Closed)

Created:
4 years, 2 months ago by David Tseng
Modified:
4 years, 1 month ago
Reviewers:
nektarios
CC:
aboxhall+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work around bad line break offset calculation Line breaks, as computed by AXNode, are wrong. One instance is the very last start offset it pushes. Since there's no way for the computation to know whether the last node on a line actually results in a *text* line break (i.e. a line break represented in the selection), it's unreliable and causes problems. For now, work around it in ChromeVox by just ignoring the last line break offset. BUG=652059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
David Tseng
4 years, 2 months ago (2016-10-06 21:25:16 UTC) #4
nektarios
4 years, 2 months ago (2016-10-07 21:37:34 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698