[NTP Snippets] Persist remote categories in prefs

components/ntp_snippets/remote/ntp_snippets_service_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/remote/ntp_snippets_service.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
@@ skipping 720 matching lines @@
     EXPECT_EQ(MakeOtherID(std::string(kSnippetUrl) + "/1"), suggestion.id());
     EXPECT_EQ(kSnippetTitle, base::UTF16ToUTF8(suggestion.title()));
     EXPECT_EQ(kSnippetText, base::UTF16ToUTF8(suggestion.snippet_text()));
     EXPECT_EQ(GetDefaultCreationTime(), suggestion.publish_date());
     EXPECT_EQ(kSnippetPublisherName,
               base::UTF16ToUTF8(suggestion.publisher_name()));
     EXPECT_EQ(GURL(kSnippetAmpUrl), suggestion.amp_url());
   }
 }
 
+TEST_F(NTPSnippetsServiceTest, PersistCategoryInfos) {
+  std::string json_str(
+      GetMultiCategoryJson({GetSnippetN(0)}, {GetSnippetN(1)}));

[tschumann, 2016/10/07 14:45:55]

inline json_str?

[Marc Treib, 2016/10/07 15:29:55]

Done.

+
+  auto service = MakeSnippetsService();
+
+  LoadFromJSONString(service.get(), json_str);
+
+  ASSERT_NE(observer().StatusForCategory(articles_category()),
+            CategoryStatus::NOT_PROVIDED);
+  ASSERT_NE(observer().StatusForCategory(other_category()),

[tschumann, 2016/10/07 14:45:55]

ideally, this method would be called unknown_category() or
remote_unknown_category().

[Marc Treib, 2016/10/07 15:29:55]

Hm. There's corresponding MakeArticleID/MakeOtherID - IMO MakeUnknownID would be
a bit weird.
I tend to think "other" is unspecific enough. Unless you feel strongly, I'd
leave it as is.

[tschumann, 2016/10/07 16:12:45]

The problem I'm seeing is that in this case, we don't want to be unspecific. If
it's a known ID then the test might just pass accidentally.
We could of course just create the category here our selves ;-)

[Marc Treib, 2016/10/10 08:33:42]

Alright, made an unknown_category.

+            CategoryStatus::NOT_PROVIDED);
+
+  CategoryInfo info_articles_before =
+      service->GetCategoryInfo(articles_category());
+  CategoryInfo info_other_before = service->GetCategoryInfo(other_category());
+
+  // Recreate the service to simulate a Chrome restart.
+  ResetSnippetsService(&service);
+
+  // The categories should have been restored.
+  ASSERT_NE(observer().StatusForCategory(articles_category()),
+            CategoryStatus::NOT_PROVIDED);
+  ASSERT_NE(observer().StatusForCategory(other_category()),
+            CategoryStatus::NOT_PROVIDED);
+
+  CategoryInfo info_articles_after =
+      service->GetCategoryInfo(articles_category());
+  CategoryInfo info_other_after = service->GetCategoryInfo(other_category());
+
+  EXPECT_EQ(info_articles_before.title(), info_articles_after.title());
+  EXPECT_EQ(info_other_before.title(), info_other_after.title());
+}
+
 TEST_F(NTPSnippetsServiceTest, Clear) {
   auto service = MakeSnippetsService();
 
   std::string json_str(GetTestJson({GetSnippet()}));
 
   LoadFromJSONString(service.get(), json_str);
   EXPECT_THAT(service->GetSnippetsForTesting(articles_category()), SizeIs(1));
 
   service->ClearCachedSuggestions(articles_category());
   EXPECT_THAT(service->GetSnippetsForTesting(articles_category()), IsEmpty());
@@ skipping 479 matching lines @@
         base::StringPrintf("http://localhost/snippet-id-%d", i)));
   }
   LoadFromJSONString(service.get(), GetTestJson(suggestions));
   // TODO(tschumann): We should probably trim out any additional results and
   // only serve the MaxSnippetCount items.
   EXPECT_THAT(service->GetSnippetsForTesting(articles_category()),
               SizeIs(service->GetMaxSnippetCountForTesting() + 1));
 }
 
 }  // namespace ntp_snippets