Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2395273002: Assorted Android fixes (Closed)

Created:
4 years, 2 months ago by f(malita)
Modified:
4 years, 2 months ago
Reviewers:
djsollen, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M tools/android/SkAndroidSDKCanvas.h View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/android/SkAndroidSDKCanvas.cpp View 3 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
f(malita)
Some of these prolly have to do with missing defines for the Android tools build, ...
4 years, 2 months ago (2016-10-06 21:07:49 UTC) #3
reed1
lgtm
4 years, 2 months ago (2016-10-06 21:17:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395273002/20001
4 years, 2 months ago (2016-10-06 21:19:09 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 21:37:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2766cc567d5c939730fadd2d865e4bdf05477263

Powered by Google App Engine
This is Rietveld 408576698