Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: components/translate/core/browser/translate_ranker_unittest.cc

Issue 2395253002: Send TranslateEventProtos to UMA. (Closed)
Patch Set: Remove Record interface from client. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate/core/browser/translate_ranker_metrics_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/browser/translate_ranker_unittest.cc
diff --git a/components/translate/core/browser/translate_ranker_unittest.cc b/components/translate/core/browser/translate_ranker_unittest.cc
index 8c1f1b2927efaa7b83abf530d22dc31cd4656b77..7b075d128443731263bef33f9c56c863a9639648 100644
--- a/components/translate/core/browser/translate_ranker_unittest.cc
+++ b/components/translate/core/browser/translate_ranker_unittest.cc
@@ -10,6 +10,7 @@
#include "base/feature_list.h"
#include "base/strings/stringprintf.h"
#include "base/test/scoped_feature_list.h"
+#include "components/metrics/proto/translate_event.pb.h"
#include "components/pref_registry/testing_pref_service_syncable.h"
#include "components/prefs/scoped_user_pref_update.h"
#include "components/translate/core/browser/proto/translate_ranker_model.pb.h"
@@ -80,6 +81,21 @@ class TranslateRankerTest : public ::testing::Test {
static double Sigmoid(double x) { return 1.0 / (1.0 + exp(-x)); }
+ static metrics::TranslateEventProto CreateTranslateEvent(
+ const std::string& src_lang,
+ const std::string& dst_lang,
+ int accept_count,
+ int decline_count,
+ int ignore_count) {
+ metrics::TranslateEventProto translate_event;
+ translate_event.set_source_language(src_lang);
+ translate_event.set_target_language(dst_lang);
+ translate_event.set_accept_count(accept_count);
+ translate_event.set_decline_count(decline_count);
+ translate_event.set_ignore_count(ignore_count);
+ return translate_event;
+ }
+
static const char* const kPreferredLanguagePrefs;
std::unique_ptr<user_prefs::TestingPrefServiceSyncable> prefs_;
@@ -125,8 +141,16 @@ TEST_F(TranslateRankerTest, EnableEnforcement) {
TEST_F(TranslateRankerTest, EnableQueryAndEnforcement) {
InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement}, {});
EXPECT_TRUE(TranslateRanker::IsEnabled());
+ EXPECT_FALSE(TranslateRanker::IsLoggingEnabled());
}
+TEST_F(TranslateRankerTest, EnableLogging) {
+ InitFeatures({kTranslateRankerLogging}, {});
+ EXPECT_FALSE(TranslateRanker::IsEnabled());
+ EXPECT_TRUE(TranslateRanker::IsLoggingEnabled());
+}
+
+
TEST_F(TranslateRankerTest, CalculateScore) {
InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement}, {});
std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.01f);
@@ -156,4 +180,52 @@ TEST_F(TranslateRankerTest, ShouldOfferTranslation) {
"en", "fr"));
}
+TEST_F(TranslateRankerTest, RecordAndFlushEvents) {
+ InitFeatures({kTranslateRankerLogging}, {});
+ std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.0f);
+ std::vector<metrics::TranslateEventProto> flushed_events;
+
+ // Check that flushing an empty cache will return an empty vector.
+ ranker->FlushTranslateEvents(&flushed_events);
+ EXPECT_EQ(0U, flushed_events.size());
+
+ auto event_1 = CreateTranslateEvent("fr", "en", 1, 0, 3);
+ auto event_2 = CreateTranslateEvent("jp", "en", 2, 0, 3);
+ auto event_3 = CreateTranslateEvent("es", "de", 4, 5, 6);
+ ranker->RecordTranslateEvent(event_1);
+ ranker->RecordTranslateEvent(event_2);
+ ranker->RecordTranslateEvent(event_3);
+
+ // Capture the data and verify that it is as expected.
+ ranker->FlushTranslateEvents(&flushed_events);
+ EXPECT_EQ(3U, flushed_events.size());
+ ASSERT_EQ("fr", flushed_events[0].source_language());
+ ASSERT_EQ("jp", flushed_events[1].source_language());
+ ASSERT_EQ("es", flushed_events[2].source_language());
+
+ // Check that the cache has been cleared.
+ ranker->FlushTranslateEvents(&flushed_events);
+ EXPECT_EQ(0U, flushed_events.size());
+}
+
+TEST_F(TranslateRankerTest, LoggingDisabled) {
+ InitFeatures({}, {kTranslateRankerLogging});
+ std::unique_ptr<translate::TranslateRanker> ranker = GetRankerForTest(0.0f);
+ std::vector<metrics::TranslateEventProto> flushed_events;
+
+ ranker->FlushTranslateEvents(&flushed_events);
+ EXPECT_EQ(0U, flushed_events.size());
+
+ auto event_1 = CreateTranslateEvent("fr", "en", 1, 0, 3);
+ auto event_2 = CreateTranslateEvent("jp", "en", 2, 0, 3);
+ auto event_3 = CreateTranslateEvent("es", "de", 4, 5, 6);
+ ranker->RecordTranslateEvent(event_1);
+ ranker->RecordTranslateEvent(event_2);
+ ranker->RecordTranslateEvent(event_3);
+
+ // Logging is disabled, so no events should be cached.
+ ranker->FlushTranslateEvents(&flushed_events);
+ EXPECT_EQ(0U, flushed_events.size());
+}
+
} // namespace translate
« no previous file with comments | « components/translate/core/browser/translate_ranker_metrics_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698