Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: components/translate/core/browser/translate_ranker.cc

Issue 2395253002: Send TranslateEventProtos to UMA. (Closed)
Patch Set: Remove Record interface from client. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ranker.cc
diff --git a/components/translate/core/browser/translate_ranker.cc b/components/translate/core/browser/translate_ranker.cc
index 358675025ec78fbedfcdddd5dd152d3bb0367fef..5d6b6b03992ade9e5a7e30e01d5a9dce6226b48b 100644
--- a/components/translate/core/browser/translate_ranker.cc
+++ b/components/translate/core/browser/translate_ranker.cc
@@ -12,6 +12,7 @@
#include "base/metrics/histogram_macros.h"
#include "base/profiler/scoped_tracker.h"
#include "base/strings/string_util.h"
+#include "components/metrics/proto/translate_event.pb.h"
#include "components/translate/core/browser/proto/translate_ranker_model.pb.h"
#include "components/translate/core/browser/translate_download_manager.h"
#include "components/translate/core/browser/translate_prefs.h"
@@ -86,6 +87,9 @@ const base::Feature kTranslateRankerQuery{"TranslateRankerQuery",
const base::Feature kTranslateRankerEnforcement{
"TranslateRankerEnforcement", base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kTranslateRankerLogging{"TranslateRankerLogging",
+ base::FEATURE_DISABLED_BY_DEFAULT};
+
TranslateRanker::~TranslateRanker() {}
// static
@@ -94,6 +98,11 @@ bool TranslateRanker::IsEnabled() {
}
// static
+bool TranslateRanker::IsLoggingEnabled() {
+ return base::FeatureList::IsEnabled(kTranslateRankerLogging);
+}
+
+// static
TranslateRanker* TranslateRanker::GetInstance() {
return base::Singleton<TranslateRanker>::get();
}
@@ -282,4 +291,18 @@ void TranslateRanker::ParseModel(int /* id */,
model_fetcher_.reset();
}
+void TranslateRanker::FlushTranslateEvents(
+ std::vector<metrics::TranslateEventProto>* translate_events) {
+ if (IsLoggingEnabled()) {
+ translate_events->swap(translate_events_cache_);
+ translate_events_cache_.clear();
+ }
+}
+
+void TranslateRanker::RecordTranslateEvent(
+ const metrics::TranslateEventProto& translate_event) {
+ if (IsLoggingEnabled())
+ translate_events_cache_.push_back(translate_event);
+}
+
} // namespace translate

Powered by Google App Engine
This is Rietveld 408576698