Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Side by Side Diff: components/translate/core/browser/translate_ranker_metrics_provider.cc

Issue 2395253002: Send TranslateEventProtos to UMA. (Closed)
Patch Set: Remove Record interface from client. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/translate_ranker_metrics_provider.h" 5 #include "components/translate/core/browser/translate_ranker_metrics_provider.h"
6 6
7 #include "base/metrics/sparse_histogram.h" 7 #include "base/metrics/sparse_histogram.h"
8 #include "components/metrics/proto/chrome_user_metrics_extension.pb.h"
9 #include "components/metrics/proto/translate_event.pb.h"
8 #include "components/translate/core/browser/proto/translate_ranker_model.pb.h" 10 #include "components/translate/core/browser/proto/translate_ranker_model.pb.h"
9 #include "components/translate/core/browser/translate_ranker.h" 11 #include "components/translate/core/browser/translate_ranker.h"
10 12
11 namespace translate { 13 namespace translate {
12 14
13 TranslateRankerMetricsProvider::TranslateRankerMetricsProvider() {} 15 TranslateRankerMetricsProvider::TranslateRankerMetricsProvider() {}
14 TranslateRankerMetricsProvider::~TranslateRankerMetricsProvider() {} 16 TranslateRankerMetricsProvider::~TranslateRankerMetricsProvider() {}
15 17
16 void TranslateRankerMetricsProvider::ProvideGeneralMetrics( 18 void TranslateRankerMetricsProvider::ProvideGeneralMetrics(
17 metrics::ChromeUserMetricsExtension* /* uma_proto */) { 19 metrics::ChromeUserMetricsExtension* uma_proto) {
18 // Nothing to report if the translate ranker is disabled. 20 TranslateRanker* translate_ranker = TranslateRanker::GetInstance();
19 if (!TranslateRanker::IsEnabled()) 21 if (translate_ranker != nullptr) {
20 return; 22 std::vector<metrics::TranslateEventProto> translate_events;
23 translate_ranker->FlushTranslateEvents(&translate_events);
24 for (metrics::TranslateEventProto& event : translate_events) {
25 uma_proto->add_translate_event()->Swap(&event);
26 }
21 27
22 const TranslateRanker* translate_ranker = TranslateRanker::GetInstance(); 28 if (TranslateRanker::IsEnabled()) {
23 if (translate_ranker != nullptr) { 29 // TODO(hamelphi): Remove this logging once we start using
24 UMA_HISTOGRAM_SPARSE_SLOWLY("Translate.Ranker.Model.Version", 30 // TranslateEventProtos.
25 translate_ranker->GetModelVersion()); 31 UMA_HISTOGRAM_SPARSE_SLOWLY("Translate.Ranker.Model.Version",
32 translate_ranker->GetModelVersion());
33 }
26 } 34 }
27 } 35 }
28 36
29 } // namespace translate 37 } // namespace translate
OLDNEW
« no previous file with comments | « components/translate/core/browser/translate_ranker.cc ('k') | components/translate/core/browser/translate_ranker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698