Issue 2395243008: Revert "dart2js: Constant fold num.round()"

Issue 2395243008: Revert "dart2js: Constant fold num.round()" (Closed)

Created:
4 years, 2 months ago by sra1

Modified:
4 years, 2 months ago

Reviewers:

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "dart2js: Constant fold num.round()" This reverts commit 3d28d0841319243838f057309cee8171411ab028. It appears that Safari does not round the same as other browsers. TBR=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/2eadef53b722dede80153450900bf86497d13b8a

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -238 lines)			Patch
M	pkg/compiler/lib/src/constant_system_dart.dart	View	3 chunks	+11 lines, -13 lines	0 comments	Download
M	pkg/compiler/lib/src/constants/constant_system.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_backend/constant_system_javascript.dart	View	2 chunks	+1 line, -27 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart	View	4 chunks	+6 lines, -30 lines	0 comments	Download
D	tests/compiler/dart2js_extra/round_constant_folding_test.dart	View	1 chunk	+0 lines, -167 lines	0 comments	Download

Total messages: 3 (2 generated)

sra1

4 years, 2 months ago (2016-10-08 00:00:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2eadef53b722dede80153450900bf86497d13b8a (presubmit successful).