chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm - Issue 2395233005: [Mac] Preserve original selection when suggesting completions with diacritics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 2395233005: [Mac] Preserve original selection when suggesting completions with diacritics (Closed)

Patch Set: Expose actualSelectionRange as a property change calls to selectedRange to use it instead when appr… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

index 556dfc799e8c77cd3b47fdd877ce0a18d3bd4cc0..1439db1cd29174e9780f57863dbb0d3e398dd440 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

@@ -324,7 +324,10 @@ base::string16 OmniboxViewMac::GetText() const {

}

NSRange OmniboxViewMac::GetSelectedRange() const {

- return [[field_ currentEditor] selectedRange];

+ AutocompleteTextFieldEditor* editor =

+ base::mac::ObjCCastStrict<AutocompleteTextFieldEditor>(

+ [field_ currentEditor]);

+ return editor.actualSelectedRange;

}

NSRange OmniboxViewMac::GetMarkedRange() const {