Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2395233004: Revert of [Telemetry] Add 'check_independent' command to benchmark_runner (Closed)

Created:
4 years, 2 months ago by eakuefner
Modified:
4 years, 2 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Add 'check_independent' command to benchmark_runner (patchset #4 id:60001 of https://codereview.chromium.org/2291313002/ ) Reason for revert: No longer needed. Original issue's description: > [Telemetry] Add 'check_independent' command to benchmark_runner > > This CL adds a new 'check_independent' subcommand to benchmark_runner, which returns > 0 if stories are independent (can be run alone reliably using --story-filter), > or 1 if not. > > It also adds a new strategy for integration testing benchmark_runner. > > BUG=catapult:#1811 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/60197f381eba6f956d3b264530925b3b452ab9dc TBR=dtu@chromium.org,nednguyen@google.com,nednguyen@chromium.org,sullivan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=catapult:#1811 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b1d2bdcb8df1fe5274df1dc6ec8627ab296263b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -81 lines) Patch
M telemetry/examples/run_benchmark View 1 chunk +1 line, -2 lines 0 comments Download
M telemetry/telemetry/benchmark_runner.py View 5 chunks +3 lines, -26 lines 0 comments Download
M telemetry/telemetry/benchmark_runner_unittest.py View 2 chunks +0 lines, -25 lines 0 comments Download
D telemetry/telemetry/testdata/__init__.py View 1 chunk +0 lines, -4 lines 0 comments Download
D telemetry/telemetry/testdata/run_benchmark_integration_test_benchmarks.py View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eakuefner
Created Revert of [Telemetry] Add 'check_independent' command to benchmark_runner
4 years, 2 months ago (2016-10-07 16:18:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395233004/1
4 years, 2 months ago (2016-10-07 16:18:48 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 16:47:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698