Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: src/factory.cc

Issue 2395233003: [modules] Give Module an internal [hash] field (Closed)
Patch Set: Fix merge Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/factory.cc
diff --git a/src/factory.cc b/src/factory.cc
index 9fff37ef5a4c80cf2ae176d06cf8fe6c4f9d6385..075ea0cdeb38bba4ab2c08728dab9b4153efa445 100644
--- a/src/factory.cc
+++ b/src/factory.cc
@@ -1762,11 +1762,6 @@ Handle<Module> Factory::NewModule(Handle<SharedFunctionInfo> code) {
requested_modules_length > 0 ? NewFixedArray(requested_modules_length)
: empty_fixed_array();
- // To make it easy to hash Modules, we set a new symbol as the name of
- // SharedFunctionInfo representing this Module.
- Handle<Symbol> name_symbol = NewSymbol();
- code->set_name(*name_symbol);
-
Handle<Module> module = Handle<Module>::cast(NewStruct(MODULE_TYPE));
module->set_code(*code);
module->set_embedder_data(isolate()->heap()->undefined_value());
@@ -1774,6 +1769,8 @@ Handle<Module> Factory::NewModule(Handle<SharedFunctionInfo> code) {
module->set_flags(0);
module->set_module_namespace(isolate()->heap()->undefined_value());
module->set_requested_modules(*requested_modules);
+ module->set_embedder_data(isolate()->heap()->undefined_value());
+ module->set_hash(isolate()->GenerateIdentityHash(Smi::kMaxValue));
return module;
}
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698