Revert of [Reland] Refactor WebappRegistry into a singleton instance.

Revert of [Reland] Refactor WebappRegistry into a singleton instance. (patchset #14 id:260001 of https://codereview.chromium.org/2351113005/ )

Reason for revert:
chrome_public_test_apk test failures in WebappSplashScreenTest.

https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/155149

failures:
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testRegularSplashScreenAppears
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testSmallSplashScreenAppears

Original issue's description:
> [Reland] Refactor WebappRegistry into a singleton instance.
>
> This CL refactors WebappRegistry and WebappDataStorage to make most of
> the methods synchronous. WebappRegistry is now a singleton instance that
> is instantiated at browser startup. This allows all SharedPreferences files to
> be pre-warmed before the class is used; new web apps open new
> SharedPreferences on a background thread when registered, after which the
> preferences are cached automatically.
>
> Most static methods on WebappRegistry and WebappDataStorage have been
> converted to instance methods or removed. This makes the code much
> cleaner and more efficient; each static method had to independently open
> their SharedPreferences, which minimally performs a stat() on the
> underlying XML file to see if it has changed. Now the singleton
> WebappRegistry caches all WebappDataStorage objects on startup and
> whenever new ones are added. This reduces disk IO overhead.
>
> This CL allows all calls to SharedPreferences.Editor.apply() in
> WebappRegistry and WebappDataStorage to occur on the main thread,
> mostly removing the need for unwieldy callback interfaces and bare
> pointer passing across the JNI.
>
> BUG=633791
>
> Committed: https://crrev.com/8d4f92312dc1b0cb0bfcfe8ffd981b3555bfd537
> Cr-Commit-Position: refs/heads/master@{#423389}

TBR=dfalcantara@chromium.org,wnwen@chromium.org,msramek@chromium.org,dominickn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633791
Committed: https://crrev.com/0d4dfd29bee0715867058fa36823f6161a883f85
Cr-Commit-Position: refs/heads/master@{#423597}

[nasko, 2016-10-06 18:29:27]

The CQ bit was checked by nasko@chromium.org

[nasko, 2016-10-06 18:29:27]

Created Revert of [Reland] Refactor WebappRegistry into a singleton instance.

[commit-bot: I haz the power, 2016-10-06 18:30:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 18:33:46]

Description was changed from

==========
Revert of [Reland] Refactor WebappRegistry into a singleton instance. (patchset
#14 id:260001 of https://codereview.chromium.org/2351113005/ )

Reason for revert:
chrome_public_test_apk test failures in WebappSplashScreenTest.

https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...

failures:
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testRegularSplashScreenAppears
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testSmallSplashScreenAppears


Original issue's description:
> [Reland] Refactor WebappRegistry into a singleton instance.
> 
> This CL refactors WebappRegistry and WebappDataStorage to make most of
> the methods synchronous. WebappRegistry is now a singleton instance that
> is instantiated at browser startup. This allows all SharedPreferences files to
> be pre-warmed before the class is used; new web apps open new
> SharedPreferences on a background thread when registered, after which the
> preferences are cached automatically.
> 
> Most static methods on WebappRegistry and WebappDataStorage have been
> converted to instance methods or removed. This makes the code much
> cleaner and more efficient; each static method had to independently open
> their SharedPreferences, which minimally performs a stat() on the
> underlying XML file to see if it has changed. Now the singleton
> WebappRegistry caches all WebappDataStorage objects on startup and
> whenever new ones are added. This reduces disk IO overhead.
> 
> This CL allows all calls to SharedPreferences.Editor.apply() in
> WebappRegistry and WebappDataStorage to occur on the main thread,
> mostly removing the need for unwieldy callback interfaces and bare
> pointer passing across the JNI.
> 
> BUG=633791
> 
> Committed: https://crrev.com/8d4f92312dc1b0cb0bfcfe8ffd981b3555bfd537
> Cr-Commit-Position: refs/heads/master@{#423389}

TBR=dfalcantara@chromium.org,wnwen@chromium.org,msramek@chromium.org,dominick...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633791
==========

to

==========
Revert of [Reland] Refactor WebappRegistry into a singleton instance. (patchset
#14 id:260001 of https://codereview.chromium.org/2351113005/ )

Reason for revert:
chrome_public_test_apk test failures in WebappSplashScreenTest.

https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...

failures:
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testRegularSplashScreenAppears
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testSmallSplashScreenAppears


Original issue's description:
> [Reland] Refactor WebappRegistry into a singleton instance.
> 
> This CL refactors WebappRegistry and WebappDataStorage to make most of
> the methods synchronous. WebappRegistry is now a singleton instance that
> is instantiated at browser startup. This allows all SharedPreferences files to
> be pre-warmed before the class is used; new web apps open new
> SharedPreferences on a background thread when registered, after which the
> preferences are cached automatically.
> 
> Most static methods on WebappRegistry and WebappDataStorage have been
> converted to instance methods or removed. This makes the code much
> cleaner and more efficient; each static method had to independently open
> their SharedPreferences, which minimally performs a stat() on the
> underlying XML file to see if it has changed. Now the singleton
> WebappRegistry caches all WebappDataStorage objects on startup and
> whenever new ones are added. This reduces disk IO overhead.
> 
> This CL allows all calls to SharedPreferences.Editor.apply() in
> WebappRegistry and WebappDataStorage to occur on the main thread,
> mostly removing the need for unwieldy callback interfaces and bare
> pointer passing across the JNI.
> 
> BUG=633791
> 
> Committed: https://crrev.com/8d4f92312dc1b0cb0bfcfe8ffd981b3555bfd537
> Cr-Commit-Position: refs/heads/master@{#423389}

TBR=dfalcantara@chromium.org,wnwen@chromium.org,msramek@chromium.org,dominick...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633791
==========

[commit-bot: I haz the power, 2016-10-06 18:33:47]

Committed patchset #1 (id:1)

[nasko, 2016-10-06 18:33:48]

Description was changed from

==========
Revert of [Reland] Refactor WebappRegistry into a singleton instance. (patchset
#14 id:260001 of https://codereview.chromium.org/2351113005/ )

Reason for revert:
chrome_public_test_apk test failures in WebappSplashScreenTest.

https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...

failures:
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testRegularSplashScreenAppears
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testSmallSplashScreenAppears


Original issue's description:
> [Reland] Refactor WebappRegistry into a singleton instance.
> 
> This CL refactors WebappRegistry and WebappDataStorage to make most of
> the methods synchronous. WebappRegistry is now a singleton instance that
> is instantiated at browser startup. This allows all SharedPreferences files to
> be pre-warmed before the class is used; new web apps open new
> SharedPreferences on a background thread when registered, after which the
> preferences are cached automatically.
> 
> Most static methods on WebappRegistry and WebappDataStorage have been
> converted to instance methods or removed. This makes the code much
> cleaner and more efficient; each static method had to independently open
> their SharedPreferences, which minimally performs a stat() on the
> underlying XML file to see if it has changed. Now the singleton
> WebappRegistry caches all WebappDataStorage objects on startup and
> whenever new ones are added. This reduces disk IO overhead.
> 
> This CL allows all calls to SharedPreferences.Editor.apply() in
> WebappRegistry and WebappDataStorage to occur on the main thread,
> mostly removing the need for unwieldy callback interfaces and bare
> pointer passing across the JNI.
> 
> BUG=633791
> 
> Committed: https://crrev.com/8d4f92312dc1b0cb0bfcfe8ffd981b3555bfd537
> Cr-Commit-Position: refs/heads/master@{#423389}

TBR=dfalcantara@chromium.org,wnwen@chromium.org,msramek@chromium.org,dominick...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633791
==========

to

==========
Revert of [Reland] Refactor WebappRegistry into a singleton instance. (patchset
#14 id:260001 of https://codereview.chromium.org/2351113005/ )

Reason for revert:
chrome_public_test_apk test failures in WebappSplashScreenTest.

https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...

failures:
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testRegularSplashScreenAppears
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testSmallSplashScreenAppears


Original issue's description:
> [Reland] Refactor WebappRegistry into a singleton instance.
> 
> This CL refactors WebappRegistry and WebappDataStorage to make most of
> the methods synchronous. WebappRegistry is now a singleton instance that
> is instantiated at browser startup. This allows all SharedPreferences files to
> be pre-warmed before the class is used; new web apps open new
> SharedPreferences on a background thread when registered, after which the
> preferences are cached automatically.
> 
> Most static methods on WebappRegistry and WebappDataStorage have been
> converted to instance methods or removed. This makes the code much
> cleaner and more efficient; each static method had to independently open
> their SharedPreferences, which minimally performs a stat() on the
> underlying XML file to see if it has changed. Now the singleton
> WebappRegistry caches all WebappDataStorage objects on startup and
> whenever new ones are added. This reduces disk IO overhead.
> 
> This CL allows all calls to SharedPreferences.Editor.apply() in
> WebappRegistry and WebappDataStorage to occur on the main thread,
> mostly removing the need for unwieldy callback interfaces and bare
> pointer passing across the JNI.
> 
> BUG=633791
> 
> Committed: https://crrev.com/8d4f92312dc1b0cb0bfcfe8ffd981b3555bfd537
> Cr-Commit-Position: refs/heads/master@{#423389}

TBR=dfalcantara@chromium.org,wnwen@chromium.org,msramek@chromium.org,dominick...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633791, 653627
==========

[commit-bot: I haz the power, 2016-10-06 18:37:23]

Description was changed from

==========
Revert of [Reland] Refactor WebappRegistry into a singleton instance. (patchset
#14 id:260001 of https://codereview.chromium.org/2351113005/ )

Reason for revert:
chrome_public_test_apk test failures in WebappSplashScreenTest.

https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...

failures:
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testRegularSplashScreenAppears
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testSmallSplashScreenAppears


Original issue's description:
> [Reland] Refactor WebappRegistry into a singleton instance.
> 
> This CL refactors WebappRegistry and WebappDataStorage to make most of
> the methods synchronous. WebappRegistry is now a singleton instance that
> is instantiated at browser startup. This allows all SharedPreferences files to
> be pre-warmed before the class is used; new web apps open new
> SharedPreferences on a background thread when registered, after which the
> preferences are cached automatically.
> 
> Most static methods on WebappRegistry and WebappDataStorage have been
> converted to instance methods or removed. This makes the code much
> cleaner and more efficient; each static method had to independently open
> their SharedPreferences, which minimally performs a stat() on the
> underlying XML file to see if it has changed. Now the singleton
> WebappRegistry caches all WebappDataStorage objects on startup and
> whenever new ones are added. This reduces disk IO overhead.
> 
> This CL allows all calls to SharedPreferences.Editor.apply() in
> WebappRegistry and WebappDataStorage to occur on the main thread,
> mostly removing the need for unwieldy callback interfaces and bare
> pointer passing across the JNI.
> 
> BUG=633791
> 
> Committed: https://crrev.com/8d4f92312dc1b0cb0bfcfe8ffd981b3555bfd537
> Cr-Commit-Position: refs/heads/master@{#423389}

TBR=dfalcantara@chromium.org,wnwen@chromium.org,msramek@chromium.org,dominick...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633791, 653627
==========

to

==========
Revert of [Reland] Refactor WebappRegistry into a singleton instance. (patchset
#14 id:260001 of https://codereview.chromium.org/2351113005/ )

Reason for revert:
chrome_public_test_apk test failures in WebappSplashScreenTest.

https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...

failures:
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testRegularSplashScreenAppears
org.chromium.chrome.browser.webapps.WebappSplashScreenTest#testSmallSplashScreenAppears

Original issue's description:
> [Reland] Refactor WebappRegistry into a singleton instance.
>
> This CL refactors WebappRegistry and WebappDataStorage to make most of
> the methods synchronous. WebappRegistry is now a singleton instance that
> is instantiated at browser startup. This allows all SharedPreferences files to
> be pre-warmed before the class is used; new web apps open new
> SharedPreferences on a background thread when registered, after which the
> preferences are cached automatically.
>
> Most static methods on WebappRegistry and WebappDataStorage have been
> converted to instance methods or removed. This makes the code much
> cleaner and more efficient; each static method had to independently open
> their SharedPreferences, which minimally performs a stat() on the
> underlying XML file to see if it has changed. Now the singleton
> WebappRegistry caches all WebappDataStorage objects on startup and
> whenever new ones are added. This reduces disk IO overhead.
>
> This CL allows all calls to SharedPreferences.Editor.apply() in
> WebappRegistry and WebappDataStorage to occur on the main thread,
> mostly removing the need for unwieldy callback interfaces and bare
> pointer passing across the JNI.
>
> BUG=633791
>
> Committed: https://crrev.com/8d4f92312dc1b0cb0bfcfe8ffd981b3555bfd537
> Cr-Commit-Position: refs/heads/master@{#423389}

TBR=dfalcantara@chromium.org,wnwen@chromium.org,msramek@chromium.org,dominick...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633791

Committed: https://crrev.com/0d4dfd29bee0715867058fa36823f6161a883f85
Cr-Commit-Position: refs/heads/master@{#423597}
==========

[commit-bot: I haz the power, 2016-10-06 18:37:24]

Patchset 1 (id:??) landed as
https://crrev.com/0d4dfd29bee0715867058fa36823f6161a883f85
Cr-Commit-Position: refs/heads/master@{#423597}