Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: components/offline_pages/background/request_picker.h

Issue 2395213002: Implement disabled list (Closed)
Patch Set: Pass the disabled list when looking for a new request. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_picker.h
diff --git a/components/offline_pages/background/request_picker.h b/components/offline_pages/background/request_picker.h
index 0f80dd7b2ed8c9e3df0a6d479a78931d9425efde..58828c02707db18a7910a9a6598981346014d6da 100644
--- a/components/offline_pages/background/request_picker.h
+++ b/components/offline_pages/background/request_picker.h
@@ -6,6 +6,7 @@
#define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_PICKER_H_
#include <memory>
+#include <set>
#include "base/memory/weak_ptr.h"
#include "components/offline_pages/background/device_conditions.h"
@@ -35,11 +36,13 @@ class RequestPicker {
void ChooseNextRequest(
RequestCoordinator::RequestPickedCallback picked_callback,
RequestCoordinator::RequestNotPickedCallback not_picked_callback,
- DeviceConditions* device_conditions);
+ DeviceConditions* device_conditions,
+ std::set<int64_t>* disabled_requests);
Dmitry Titov 2016/10/10 17:18:06 Could it be const std::set<...>& here since it won
Pete Williamson 2016/10/10 18:24:49 Done.
private:
// Callback for the GetRequest results to be delivered.
void GetRequestResultCallback(
+ std::set<int64_t>* disabled_requests,
RequestQueue::GetRequestsResult result,
std::vector<std::unique_ptr<SavePageRequest>> results);
« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | components/offline_pages/background/request_picker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698