Implement disabled list

Implement disabled list

To promote using the original tab as the primary download source
for a page, we are making changes to disable a page for background
downloading until the foreground is done. This part of the larger
change implements the disabled list.

BUG=652889
Committed: https://crrev.com/f75ba66f9a4b29bc62d2716b3a2816cc69b8b271
Cr-Commit-Position: refs/heads/master@{#424226}

[Pete Williamson, 2016-10-06 17:36:15]

petewil@chromium.org changed reviewers:
+ dimich@chromium.org

[Pete Williamson, 2016-10-07 21:58:39]

Added change as suggested offline by Dimich, and a test.

[Dmitry Titov, 2016-10-10 17:18:06]

lgtm with a nit to address:

https://codereview.chromium.org/2395213002/diff/20001/components/offline_page...
File components/offline_pages/background/request_picker.h (right):

https://codereview.chromium.org/2395213002/diff/20001/components/offline_page...
components/offline_pages/background/request_picker.h:40: std::set<int64_t>*
disabled_requests);
Could it be const std::set<...>& here since it won't be changed by the code in
the RequestPicker during that operation?

[Pete Williamson, 2016-10-10 18:24:49]

https://codereview.chromium.org/2395213002/diff/20001/components/offline_page...
File components/offline_pages/background/request_picker.h (right):

https://codereview.chromium.org/2395213002/diff/20001/components/offline_page...
components/offline_pages/background/request_picker.h:40: std::set<int64_t>*
disabled_requests);
On 2016/10/10 17:18:06, Dmitry Titov wrote:
> Could it be const std::set<...>& here since it won't be changed by the code in
> the RequestPicker during that operation?

Done.

[Pete Williamson, 2016-10-10 18:24:55]

The CQ bit was checked by petewil@chromium.org

[Pete Williamson, 2016-10-10 18:24:55]

The patchset sent to the CQ was uploaded after l-g-t-m from dimich@chromium.org
Link to the patchset: https://codereview.chromium.org/2395213002/#ps40001
(title: "set pointer -> const ref")

[commit-bot: I haz the power, 2016-10-10 18:25:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 19:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 19:20:04]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Pete Williamson, 2016-10-10 19:46:51]

The CQ bit was checked by petewil@chromium.org

[commit-bot: I haz the power, 2016-10-10 19:47:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 20:37:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-10 20:40:57]

Description was changed from

==========
Implement disabled list

To promote using the original tab as the primary download source
for a page, we are making changes to disable a page for background
downloading until the foreground is done. This part of the larger
change implements the disabled list.

BUG=652889
==========

to

==========
Implement disabled list

To promote using the original tab as the primary download source
for a page, we are making changes to disable a page for background
downloading until the foreground is done. This part of the larger
change implements the disabled list.

BUG=652889

Committed: https://crrev.com/f75ba66f9a4b29bc62d2716b3a2816cc69b8b271
Cr-Commit-Position: refs/heads/master@{#424226}
==========

[commit-bot: I haz the power, 2016-10-10 20:40:59]

Patchset 3 (id:??) landed as
https://crrev.com/f75ba66f9a4b29bc62d2716b3a2816cc69b8b271
Cr-Commit-Position: refs/heads/master@{#424226}