chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java - Issue 2395203002: NTP cards: Restructure change notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

Issue 2395203002: NTP cards: Restructure change notifications. (Closed)

Patch Set: x Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

index cdb994e0012f84266d205e731d2a1c98f75477b7..e75d368551259bcf0b293cc76b88fa5491046f0f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java

@@ -85,7 +85,7 @@ public class SigninPromoItem extends StatusItem implements ItemGroup {

if (mDismissed) return;

RecordUserAction.record("Signin_Impression_FromNTPContentSuggestions");

- mChangeObserver.notifyItemInserted(this, 0);

+ mChangeObserver.onItemRangeInserted(this, 0, 1);

}

/** Hides the sign in promo. */

@@ -95,7 +95,7 @@ public class SigninPromoItem extends StatusItem implements ItemGroup {

if (mDismissed) return;

- mChangeObserver.notifyItemRemoved(this, 0);

+ mChangeObserver.onItemRangeRemoved(this, 0, 1);

}

/** Hides the sign in promo and sets a preference to make sure it is not shown again. */