Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2395193002: Add auxclick to the devtool event listeners (Closed)

Created:
4 years, 2 months ago by Navid Zolghadr
Modified:
4 years, 2 months ago
Reviewers:
kozy, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add auxclick to the devtool event listeners Add auxclick under mouse events in devtool event listener breakpoints BUG=653577 Committed: https://crrev.com/1fe901f7cb3fe6653643720b51ff00f1ccd5dc23 Cr-Commit-Position: refs/heads/master@{#424795}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add the test and fix pointerevents #

Messages

Total messages: 22 (13 generated)
Navid Zolghadr
I wasn't sure if a test is needed for this case or not. There was ...
4 years, 2 months ago (2016-10-06 17:24:46 UTC) #4
lushnikov
a test will never hurt! :) https://codereview.chromium.org/2395193002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js File third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js (left): https://codereview.chromium.org/2395193002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js#oldcode38 third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js:38: this._createCategory(WebInspector.UIString("Pointer"), ["pointerover", "pointerout", ...
4 years, 2 months ago (2016-10-07 16:27:52 UTC) #7
lushnikov
Hmm, it looks like we indeed do not test every particular event. So test is ...
4 years, 2 months ago (2016-10-07 16:36:23 UTC) #9
Navid Zolghadr
ptal https://codereview.chromium.org/2395193002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js File third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js (left): https://codereview.chromium.org/2395193002/diff/1/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js#oldcode38 third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js:38: this._createCategory(WebInspector.UIString("Pointer"), ["pointerover", "pointerout", "pointerenter", "pointerleave", "pointerdown", "pointerup", "pointermove", ...
4 years, 2 months ago (2016-10-07 18:24:30 UTC) #12
lushnikov
lgtm, thanks!
4 years, 2 months ago (2016-10-07 19:30:23 UTC) #13
kozy
lgtm
4 years, 2 months ago (2016-10-07 19:46:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395193002/20001
4 years, 2 months ago (2016-10-12 14:16:58 UTC) #18
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 2 months ago (2016-10-12 18:33:27 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 18:34:30 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1fe901f7cb3fe6653643720b51ff00f1ccd5dc23
Cr-Commit-Position: refs/heads/master@{#424795}

Powered by Google App Engine
This is Rietveld 408576698