Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2395163003: Update bindings test expectatsions after refs/heads/master@{#423519} (Closed)

Created:
4 years, 2 months ago by bashi
Modified:
4 years, 2 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update bindings test expectatsions after refs/heads/master@{#423519} ASSERT_UNUSED() -> DCHECK() TBR=haraken@chromium.org Committed: https://crrev.com/b419b4597cd28926930ce41be729dde979ede794 Cr-Commit-Position: refs/heads/master@{#423818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8DataView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
bashi
I'll submit this.
4 years, 2 months ago (2016-10-07 07:19:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395163003/1
4 years, 2 months ago (2016-10-07 07:19:38 UTC) #3
haraken
LGTM
4 years, 2 months ago (2016-10-07 07:24:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 08:06:02 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 08:08:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b419b4597cd28926930ce41be729dde979ede794
Cr-Commit-Position: refs/heads/master@{#423818}

Powered by Google App Engine
This is Rietveld 408576698