WebRTC: Move Android bots with devices to the perf waterfall.

WebRTC: Move Android bots with devices to the perf waterfall.

- Set up "Android{32,64} Builder" bots in the perf waterfall using one of the VMs from the main waterfall.
- Move the baremetal machines with android devices from the main waterfall to the perf waterfall.
  * Now they only execute webrtc_perf_tests.
- Swarming bots now compile instead of downloading builds.
- Swarming bots now upload AppRTCMobile.apk.
  * This is done in a new package_apprtcmobile step.
  * Introduced should_upload_apprtcmobile.
- Deleted the android_n6 trybot and moved the machine to the fyi waterfall.
- Deleted the AndroidTest and AndroidInstrumentationTest classes and the get_android_tool function in steps, since they were not used.


BUG=583318
Committed: https://chromium.googlesource.com/chromium/tools/build/+/c8926bbb8345c443eb411f398767d40bed584ad6

[ehmaldonado_chromium, 2016-10-06 14:50:28]

Patchset #1 (id:1) has been deleted

[ehmaldonado_chromium, 2016-10-06 14:50:35]

Patchset #1 (id:10001) has been deleted

[ehmaldonado_chromium, 2016-10-06 15:15:06]

Patchset #1 (id:20001) has been deleted

[ehmaldonado_chromium, 2016-10-06 15:15:15]

Patchset #1 (id:40001) has been deleted

[ehmaldonado_chromium, 2016-10-06 15:19:02]

Patchset #1 (id:50001) has been deleted

[ehmaldonado_chromium, 2016-10-06 15:26:20]

ehmaldonado@chromium.org changed reviewers:
+ kjellander@chromium.org

[ehmaldonado_chromium, 2016-10-06 15:30:37]

Description was changed from

==========
WebRTC: Move Android bots with devices to the perf waterfall.

And make them run only webrtc_perf_tests. The rest will be run on the
swarming bots in the main waterfall.

BUG=583318
==========

to

==========
WebRTC: Move Android bots with devices to the perf waterfall.

- Set up "Android{32,64} Builder" bots in the perf waterfall using one of the
VMs from the main waterfall.
- Move the baremetal machines with android devices from the main waterfall to
the perf waterfall.
- Now they only execute webrtc_perf_tests.
- Swarming bots now compile instead of downloading builds.
- Swarming bots now upload AppRTCMobile.apk.
- Deleted the android_n6 trybot and moved the machine to the fyi waterfall.
- Deleted the AndroidTest and AndroidInstrumentationTest classes and the
get_android_tool function in steps, since they were not used.


BUG=583318
==========

[ehmaldonado_chromium, 2016-10-06 15:33:30]

Description was changed from

==========
WebRTC: Move Android bots with devices to the perf waterfall.

- Set up "Android{32,64} Builder" bots in the perf waterfall using one of the
VMs from the main waterfall.
- Move the baremetal machines with android devices from the main waterfall to
the perf waterfall.
- Now they only execute webrtc_perf_tests.
- Swarming bots now compile instead of downloading builds.
- Swarming bots now upload AppRTCMobile.apk.
- Deleted the android_n6 trybot and moved the machine to the fyi waterfall.
- Deleted the AndroidTest and AndroidInstrumentationTest classes and the
get_android_tool function in steps, since they were not used.


BUG=583318
==========

to

==========
WebRTC: Move Android bots with devices to the perf waterfall.

- Set up "Android{32,64} Builder" bots in the perf waterfall using one of the
VMs from the main waterfall.
- Move the baremetal machines with android devices from the main waterfall to
the perf waterfall.
  * Now they only execute webrtc_perf_tests.
- Swarming bots now compile instead of downloading builds.
- Swarming bots now upload AppRTCMobile.apk.
  * This is done in a new package_apprtcmobile step.
  * Introduced should_upload_apprtcmobile.
- Deleted the android_n6 trybot and moved the machine to the fyi waterfall.
- Deleted the AndroidTest and AndroidInstrumentationTest classes and the
get_android_tool function in steps, since they were not used.


BUG=583318
==========

[kjellander_chromium, 2016-10-07 07:07:15]

Nice work! Just a few minor changes.
Also, prepare a separate CL for the MB changes.

https://codereview.chromium.org/2395143002/diff/70001/masters/master.client.w...
File masters/master.client.webrtc.fyi/slaves.cfg (right):

https://codereview.chromium.org/2395143002/diff/70001/masters/master.client.w...
masters/master.client.webrtc.fyi/slaves.cfg:53: } for hostname in ('build3-b3',
'build39-b4')
You can't move build39-b4 here. It's living in an isolated VLAN. So we'll have
to file a ticket to get it renamed first (so for now just remove it instead,
just make sure we don't forget to file that ticket or we'll have a zombie
machine just sitting there).

https://codereview.chromium.org/2395143002/diff/70001/masters/master.client.w...
File masters/master.client.webrtc.perf/master.cfg (right):

https://codereview.chromium.org/2395143002/diff/70001/masters/master.client.w...
masters/master.client.webrtc.perf/master.cfg:45: {'name': 'Android32 Tests (L
Nexus5)'},
Aaah, I'm happy I prepared this waterfall already so this was the only tiny
change needed to bring them in.

https://codereview.chromium.org/2395143002/diff/70001/masters/master.client.w...
File masters/master.client.webrtc.perf/slaves.cfg (right):

https://codereview.chromium.org/2395143002/diff/70001/masters/master.client.w...
masters/master.client.webrtc.perf/slaves.cfg:8: 'master': 'WebRTC',
Sneaky thing here: the 'master' needs to be 'WebRTCPerf' now.
Same below

https://codereview.chromium.org/2395143002/diff/70001/masters/master.client.w...
File masters/master.client.webrtc/master_android_cfg.py (right):

https://codereview.chromium.org/2395143002/diff/70001/masters/master.client.w...
masters/master.client.webrtc/master_android_cfg.py:49: 'name': 'Android32 Tests
(M Nexus5X)(dbg)',
I suggest we remove 'Tests' from the name now that they're builder_tester type.
We'll loose the build history for these, but since they're completely new that's
fine.
I'm not sure if we should migrate any of the old build for Android Tests bots
into these, but since that'll be too annoying and since the logs are already
archived in logdog, I don't think it's worth the effort.

https://codereview.chromium.org/2395143002/diff/70001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/webrtc/builders.py (right):

https://codereview.chromium.org/2395143002/diff/70001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/builders.py:710: 'Android32 Builder (dbg)':
{
Let's skip Debug entirely for the perf waterfall as we discussed.

https://codereview.chromium.org/2395143002/diff/70001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/builders.py:739: 'Android32 Tests (L
Nexus5)(dbg)': {
(remove)

https://codereview.chromium.org/2395143002/diff/70001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/builders.py:766: 'Android32 Tests (L
Nexus7.2)(dbg)': {
(remove)

[ehmaldonado_chromium, 2016-10-07 08:26:30]

PTAL

https://codereview.chromium.org/2395143002/diff/70001/masters/master.client.w...
File masters/master.client.webrtc/master_android_cfg.py (right):

https://codereview.chromium.org/2395143002/diff/70001/masters/master.client.w...
masters/master.client.webrtc/master_android_cfg.py:49: 'name': 'Android32 Tests
(M Nexus5X)(dbg)',
On 2016/10/07 07:07:15, kjellander_chromium wrote:
> I suggest we remove 'Tests' from the name now that they're builder_tester
type.
> We'll loose the build history for these, but since they're completely new
that's
> fine.
> I'm not sure if we should migrate any of the old build for Android Tests bots
> into these, but since that'll be too annoying and since the logs are already
> archived in logdog, I don't think it's worth the effort.

Ok. Let's do that in another CL :)

[kjellander_chromium, 2016-10-07 12:27:40]

One more thing needed. And do you have a MB CL ready to match this?

https://codereview.chromium.org/2395143002/diff/70001/masters/master.client.w...
File masters/master.client.webrtc/master_android_cfg.py (right):

https://codereview.chromium.org/2395143002/diff/70001/masters/master.client.w...
masters/master.client.webrtc/master_android_cfg.py:49: 'name': 'Android32 Tests
(M Nexus5X)(dbg)',
On 2016/10/07 08:26:30, ehmaldonado_chromium wrote:
> On 2016/10/07 07:07:15, kjellander_chromium wrote:
> > I suggest we remove 'Tests' from the name now that they're builder_tester
> type.
> > We'll loose the build history for these, but since they're completely new
> that's
> > fine.
> > I'm not sure if we should migrate any of the old build for Android Tests
bots
> > into these, but since that'll be too annoying and since the logs are already
> > archived in logdog, I don't think it's worth the effort.
> 
> Ok. Let's do that in another CL :)

I realize I wasn't very clear: I meant I want the rename to happen now - better
do it now than later/never before we've had too many builds.

What I meant we can ignore is the fact that we'll loose all the build history
from the other Android testers.
We could have (locally on the master) moved all the logs from, let's say
'Android32 Tests (L Nexus5)' into the directory of 'Android32 (M Nexus5X)' but
that'd add a lot of confusion, so let's not bother doing that.

[ehmaldonado_chromium, 2016-10-07 13:18:55]

On 2016/10/07 12:27:40, kjellander_chromium wrote:
> One more thing needed. And do you have a MB CL ready to match this?
> 
>
https://codereview.chromium.org/2395143002/diff/70001/masters/master.client.w...
> File masters/master.client.webrtc/master_android_cfg.py (right):
> 
>
https://codereview.chromium.org/2395143002/diff/70001/masters/master.client.w...
> masters/master.client.webrtc/master_android_cfg.py:49: 'name': 'Android32
Tests
> (M Nexus5X)(dbg)',
> On 2016/10/07 08:26:30, ehmaldonado_chromium wrote:
> > On 2016/10/07 07:07:15, kjellander_chromium wrote:
> > > I suggest we remove 'Tests' from the name now that they're builder_tester
> > type.
> > > We'll loose the build history for these, but since they're completely new
> > that's
> > > fine.
> > > I'm not sure if we should migrate any of the old build for Android Tests
> bots
> > > into these, but since that'll be too annoying and since the logs are
already
> > > archived in logdog, I don't think it's worth the effort.
> > 
> > Ok. Let's do that in another CL :)
> 
> I realize I wasn't very clear: I meant I want the rename to happen now -
better
> do it now than later/never before we've had too many builds.
> 
> What I meant we can ignore is the fact that we'll loose all the build history
> from the other Android testers.
> We could have (locally on the master) moved all the logs from, let's say
> 'Android32 Tests (L Nexus5)' into the directory of 'Android32 (M Nexus5X)' but
> that'd add a lot of confusion, so let's not bother doing that.

OK, PTAL.

[kjellander_chromium, 2016-10-07 16:37:17]

lgtm

[ehmaldonado_chromium, 2016-10-07 17:08:06]

The CQ bit was checked by ehmaldonado@chromium.org

[commit-bot: I haz the power, 2016-10-07 17:08:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 17:10:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 17:10:59]

Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/31b8ef86d3ab5910)

[ehmaldonado_chromium, 2016-10-07 17:19:06]

Patchset #4 (id:120001) has been deleted

[ehmaldonado_chromium, 2016-10-07 17:19:14]

The CQ bit was checked by ehmaldonado@chromium.org

[ehmaldonado_chromium, 2016-10-07 17:19:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@chromium.org
Link to the patchset: https://codereview.chromium.org/2395143002/#ps130001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-07 17:19:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 17:24:02]

Description was changed from

==========
WebRTC: Move Android bots with devices to the perf waterfall.

- Set up "Android{32,64} Builder" bots in the perf waterfall using one of the
VMs from the main waterfall.
- Move the baremetal machines with android devices from the main waterfall to
the perf waterfall.
  * Now they only execute webrtc_perf_tests.
- Swarming bots now compile instead of downloading builds.
- Swarming bots now upload AppRTCMobile.apk.
  * This is done in a new package_apprtcmobile step.
  * Introduced should_upload_apprtcmobile.
- Deleted the android_n6 trybot and moved the machine to the fyi waterfall.
- Deleted the AndroidTest and AndroidInstrumentationTest classes and the
get_android_tool function in steps, since they were not used.


BUG=583318
==========

to

==========
WebRTC: Move Android bots with devices to the perf waterfall.

- Set up "Android{32,64} Builder" bots in the perf waterfall using one of the
VMs from the main waterfall.
- Move the baremetal machines with android devices from the main waterfall to
the perf waterfall.
  * Now they only execute webrtc_perf_tests.
- Swarming bots now compile instead of downloading builds.
- Swarming bots now upload AppRTCMobile.apk.
  * This is done in a new package_apprtcmobile step.
  * Introduced should_upload_apprtcmobile.
- Deleted the android_n6 trybot and moved the machine to the fyi waterfall.
- Deleted the AndroidTest and AndroidInstrumentationTest classes and the
get_android_tool function in steps, since they were not used.


BUG=583318

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/c8926bbb8345c443eb41...
==========

[commit-bot: I haz the power, 2016-10-07 17:24:03]

Committed patchset #4 (id:130001) as
https://chromium.googlesource.com/chromium/tools/build/+/c8926bbb8345c443eb41...