Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: ui/views/window/dialog_delegate.h

Issue 2395133003: Update comments on pressing Esc on PlatformVerificationDialog (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/protected_media_identifier_permission_context.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/window/dialog_delegate.h
diff --git a/ui/views/window/dialog_delegate.h b/ui/views/window/dialog_delegate.h
index c74f5461ab9f131376a6261deb563a448be75c49..8e122178640377b09e0336506c5d5b3a4dadf1a8 100644
--- a/ui/views/window/dialog_delegate.h
+++ b/ui/views/window/dialog_delegate.h
@@ -63,7 +63,7 @@ class VIEWS_EXPORT DialogDelegate : public ui::DialogModel,
virtual View* CreateFootnoteView();
// For Dialog boxes, if there is a "Cancel" button or no dialog button at all,
- // this is called when the user presses the "Cancel" button or the Esc key.
+ // this is called when the user presses the "Cancel" button.
// It can also be called on a close action if |Close| has not been
// overridden. This function should return true if the window can be closed
// after it returns, or false if it must remain open.
@@ -76,10 +76,11 @@ class VIEWS_EXPORT DialogDelegate : public ui::DialogModel,
virtual bool Accept();
// Called when the user closes the window without selecting an option,
- // e.g. by pressing the close button on the window or using a window manager
- // gesture. By default, this calls Accept() if the only button in the dialog
- // is Accept, Cancel() otherwise. This function should return true if the
- // window can be closed after it returns, or false if it must remain open.
+ // e.g. by pressing the close button on the window, pressing the Esc key, or
+ // using a window manager gesture. By default, this calls Accept() if the only
+ // button in the dialog is Accept, Cancel() otherwise. This function should
+ // return true if the window can be closed after it returns, or false if it
+ // must remain open.
virtual bool Close();
// Updates the properties and appearance of |button| which has been created
« no previous file with comments | « chrome/browser/media/protected_media_identifier_permission_context.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698