Update comments on pressing Esc on PlatformVerificationDialog

Update comments on pressing Esc on PlatformVerificationDialog

On the latest build pressing Esc on PlatformVerificationDialog will call
Close() instead of Cancel(). So it seems issue 467155 is fixed. Updating
comments to reflect the current state.

Also update comments in DialogDelegate.

TBR=dkrahn@chromium.org
BUG=467155, 590960
TEST=No functionality change.

Committed: https://crrev.com/aceb9ee10952068609a2859e2e54205dc593535f
Cr-Commit-Position: refs/heads/master@{#423744}

[xhwang, 2016-10-06 18:55:13]

xhwang@chromium.org changed reviewers:
+ estade@chromium.org

[xhwang, 2016-10-06 18:55:14]

estade: The BUG was fixed but I am not super clear how that happened :) Could
you please take a look especially on dialog_delegate.h to see if it makes sense
to you?

[xhwang, 2016-10-06 18:56:15]

On 2016/10/06 18:55:14, xhwang wrote:
> estade: The BUG was fixed but I am not super clear how that happened :) Could
> you please take a look especially on dialog_delegate.h to see if it makes
sense
> to you?

I suspect https://codereview.chromium.org/1686433002 could be related but I
could be wrong.

[Evan Stade, 2016-10-06 21:05:42]

thanks, lgtm. I linked the relevant CL where this changed in the bug.

[xhwang, 2016-10-06 21:33:56]

xhwang@chromium.org changed reviewers:
+ dkrahn@chromium.org, sky@chromium.org

[xhwang, 2016-10-06 21:34:42]

Description was changed from

==========
Update comments on pressing Esc on PlatformVerificationDialog

On the latest build pressing Esc on PlatformVerificationDialog will call
Close() instead of Cancel(). So it seems issue 467155 is fixed. Updating
comments to reflect the current state.

Also update comments in DialogDelegate.

BUG=467155,590960
TEST=No functionality change.
==========

to

==========
Update comments on pressing Esc on PlatformVerificationDialog

On the latest build pressing Esc on PlatformVerificationDialog will call
Close() instead of Cancel(). So it seems issue 467155 is fixed. Updating
comments to reflect the current state.

Also update comments in DialogDelegate.

TBR=dkrahn@chromium.org
BUG=467155,590960
TEST=No functionality change.
==========

[xhwang, 2016-10-06 21:36:07]

sky: Please OWNERS review the comment changes in
ui/views/window/dialog_delegate.h. See bugs for details.

TBRing dkrahn@ on trivial changes on comment changes in
chrome/browser/chromeos/attestation/platform_verification_dialog.cc

[sky, 2016-10-06 22:37:13]

How come you are using chromiumcodereview.appspot.com and not
codereview.chromium.org? Confusingly that is not the typical host to send
reviews from, and because it isn't I have to log in again.

[sky, 2016-10-06 22:37:54]

LGTM

[xhwang, 2016-10-06 22:38:53]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2016-10-06 22:39:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2016-10-06 22:40:33]

On 2016/10/06 22:37:13, sky wrote:
> How come you are using http://chromiumcodereview.appspot.com and not
> codereview.chromium.org? Confusingly that is not the typical host to send
> reviews from, and because it isn't I have to log in again.

I am not sure :) Right now I am writing on
https://codereview.chromium.org/2395133003/, I'll see where the message is sent
out after I click "Send Message"...

[xhwang, 2016-10-06 22:42:25]

On 2016/10/06 22:40:33, xhwang wrote:
> On 2016/10/06 22:37:13, sky wrote:
> > How come you are using http://chromiumcodereview.appspot.com and not
> > codereview.chromium.org? Confusingly that is not the typical host to send
> > reviews from, and because it isn't I have to log in again.
> 
> I am not sure :) Right now I am writing on
> https://codereview.chromium.org/2395133003/, I'll see where the message is
sent
> out after I click "Send Message"...

k, so my bookmarked link is https://chromiumcodereview.appspot.com/, that's
where I go to this issue https://chromiumcodereview.appspot.com/2395133003/.
When I post comments there, the message was sent from
https://chromiumcodereview.appspot.com...

[commit-bot: I haz the power, 2016-10-06 23:47:29]

Description was changed from

==========
Update comments on pressing Esc on PlatformVerificationDialog

On the latest build pressing Esc on PlatformVerificationDialog will call
Close() instead of Cancel(). So it seems issue 467155 is fixed. Updating
comments to reflect the current state.

Also update comments in DialogDelegate.

TBR=dkrahn@chromium.org
BUG=467155,590960
TEST=No functionality change.
==========

to

==========
Update comments on pressing Esc on PlatformVerificationDialog

On the latest build pressing Esc on PlatformVerificationDialog will call
Close() instead of Cancel(). So it seems issue 467155 is fixed. Updating
comments to reflect the current state.

Also update comments in DialogDelegate.

TBR=dkrahn@chromium.org
BUG=467155,590960
TEST=No functionality change.
==========

[commit-bot: I haz the power, 2016-10-06 23:47:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-06 23:50:36]

Description was changed from

==========
Update comments on pressing Esc on PlatformVerificationDialog

On the latest build pressing Esc on PlatformVerificationDialog will call
Close() instead of Cancel(). So it seems issue 467155 is fixed. Updating
comments to reflect the current state.

Also update comments in DialogDelegate.

TBR=dkrahn@chromium.org
BUG=467155,590960
TEST=No functionality change.
==========

to

==========
Update comments on pressing Esc on PlatformVerificationDialog

On the latest build pressing Esc on PlatformVerificationDialog will call
Close() instead of Cancel(). So it seems issue 467155 is fixed. Updating
comments to reflect the current state.

Also update comments in DialogDelegate.

TBR=dkrahn@chromium.org
BUG=467155,590960
TEST=No functionality change.

Committed: https://crrev.com/aceb9ee10952068609a2859e2e54205dc593535f
Cr-Commit-Position: refs/heads/master@{#423744}
==========

[commit-bot: I haz the power, 2016-10-06 23:50:38]

Patchset 1 (id:??) landed as
https://crrev.com/aceb9ee10952068609a2859e2e54205dc593535f
Cr-Commit-Position: refs/heads/master@{#423744}