Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 2395133002: Revert of [wasm] Refactor import handling for 0xC. (Closed)

Created:
4 years, 2 months ago by Michael Hablich
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Refactor import handling for 0xC. (patchset #10 id:180001 of https://codereview.chromium.org/2390113003/ ) Reason for revert: Failes a few GC stress tests.https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/6253 Original issue's description: > [wasm] Refactor import handling for 0xC. > > Imports and exports in 0xC can be much more than functions, including > tables, memories, and globals. This CL refactors the underlying > organization of imports and exports to support these new import types. > > BUG= > > Committed: https://crrev.com/599f8a83420346d9cba5ff97bd2a7520468207b6 > Cr-Commit-Position: refs/heads/master@{#40033} TBR=mtrofin@chromium.org,ahaas@chromium.org,bradnelson@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/3b1b544c205fe6913dd00e7aeef6e22984ba67ea Cr-Commit-Position: refs/heads/master@{#40038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+731 lines, -1294 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/wasm/module-decoder.cc View 4 chunks +9 lines, -16 lines 0 comments Download
M src/wasm/wasm-module.h View 5 chunks +12 lines, -12 lines 0 comments Download
M src/wasm/wasm-module.cc View 18 chunks +603 lines, -910 lines 0 comments Download
M src/wasm/wasm-module-builder.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/wasm/wasm-module-builder.cc View 2 chunks +13 lines, -49 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/compiled-module-management.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/compiled-module-serialization.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/export-table.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/ffi.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/function-prototype.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/wasm/globals.js View 1 chunk +0 lines, -66 lines 0 comments Download
M test/mjsunit/wasm/import-table.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/instance-gc.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 4 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/start-function.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/test-wasm-module-builder.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 21 chunks +61 lines, -115 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Hablich
Created Revert of [wasm] Refactor import handling for 0xC.
4 years, 2 months ago (2016-10-06 13:42:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395133002/1
4 years, 2 months ago (2016-10-06 13:42:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 13:43:06 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 13:43:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b1b544c205fe6913dd00e7aeef6e22984ba67ea
Cr-Commit-Position: refs/heads/master@{#40038}

Powered by Google App Engine
This is Rietveld 408576698