Source/core/rendering/compositing/CompositedLayerMapping.cpp - Issue 239513010: Only boxes should have child transform layers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/CompositedLayerMapping.cpp

Issue 239513010: Only boxes should have child transform layers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address reviewer feedback. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/compositing/CompositedLayerMapping.cpp

diff --git a/Source/core/rendering/compositing/CompositedLayerMapping.cpp b/Source/core/rendering/compositing/CompositedLayerMapping.cpp

index fed3dc330cc9ce041a4d39dceb14d878337b8c7e..c32b624d46060808561961fc75858a02a3282ade 100644

--- a/Source/core/rendering/compositing/CompositedLayerMapping.cpp

+++ b/Source/core/rendering/compositing/CompositedLayerMapping.cpp

@@ -476,7 +476,7 @@ bool CompositedLayerMapping::updateGraphicsLayerConfiguration(GraphicsLayerUpdat

bool hasPerspective = false;

if (RenderStyle* style = renderer->style())

hasPerspective = style->hasPerspective();

- bool needsChildTransformLayer = hasPerspective && (layerForChildrenTransform() == m_childTransformLayer.get());

+ bool needsChildTransformLayer = hasPerspective && (layerForChildrenTransform() == m_childTransformLayer.get()) && renderer->isBox();

if (updateChildTransformLayer(needsChildTransformLayer))

layerConfigChanged = true;

« no previous file with comments | « LayoutTests/compositing/child-transform-layer-requires-box-expected.txt ('k') | no next file » | no next file with comments »