Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1457)

Unified Diff: Source/core/rendering/compositing/CompositedLayerMapping.cpp

Issue 239513010: Only boxes should have child transform layers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: de-crazified the test. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/compositing/CompositedLayerMapping.cpp
diff --git a/Source/core/rendering/compositing/CompositedLayerMapping.cpp b/Source/core/rendering/compositing/CompositedLayerMapping.cpp
index 2cc35ccfd68be6e22dc764f3a602e78f997213b2..b5a7e42bbb5327445170866bbc0b3db043fb426e 100644
--- a/Source/core/rendering/compositing/CompositedLayerMapping.cpp
+++ b/Source/core/rendering/compositing/CompositedLayerMapping.cpp
@@ -476,7 +476,7 @@ bool CompositedLayerMapping::updateGraphicsLayerConfiguration(GraphicsLayerUpdat
bool hasPerspective = false;
if (RenderStyle* style = renderer->style())
hasPerspective = style->hasPerspective();
- bool needsChildTransformLayer = hasPerspective && (layerForChildrenTransform() == m_childTransformLayer.get());
+ bool needsChildTransformLayer = hasPerspective && (layerForChildrenTransform() == m_childTransformLayer.get()) && renderer->isBox();
Julien - ping for review 2014/04/17 00:02:38 Wouldn't it make more sense not to have a RenderLa
Ian Vollick 2014/04/17 01:31:03 I don't think that's possible here. You couldn't b
if (updateChildTransformLayer(needsChildTransformLayer))
layerConfigChanged = true;

Powered by Google App Engine
This is Rietveld 408576698