Issue 2395123003: Make adding a pending deopt atomic.

Issue 2395123003: Make adding a pending deopt atomic. (Closed)

Created:
4 years, 2 months ago by rmacnak

Modified:
4 years, 2 months ago

Reviewers:
Florian Schneider, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Make adding a pending deopt atomic. Issue #27496 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/b85956e6d9b64eccb6373e2df8b82e47489e1d2c

Patch Set 1 #

Total comments: 4

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -44 lines)			Patch
M	runtime/vm/code_generator.cc	View	2 chunks	+5 lines, -34 lines	0 comments	Download
M	runtime/vm/isolate.h	View	1 chunk	+4 lines, -1 line	1 comment	Download
M	runtime/vm/isolate.cc	View	1 chunk	+39 lines, -0 lines	3 comments	Download
M	runtime/vm/stack_frame.h	View	1 chunk	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

Committed patchset #1 (id:1) manually as b85956e6d9b64eccb6373e2df8b82e47489e1d2c (presubmit successful).

4 years, 2 months ago (2016-10-07 20:43:48 UTC) #5

siva

4 years, 2 months ago (2016-10-10 04:10:26 UTC) #7

Message was sent while issue was closed.

DBC

https://codereview.chromium.org/2395123003/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2395123003/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:1911: // GrowableArray::Add is not atomic and may be
interrupt by a profiler
may be interrupted ...

https://codereview.chromium.org/2395123003/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:1936: return 0;
Can another thread be executing this code while AddPendingDeopt is happening?

https://codereview.chromium.org/2395123003/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:1945: }
Same question about this function.

https://codereview.chromium.org/2395123003/diff/1/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/2395123003/diff/1/runtime/vm/isolate.h#newcod...
runtime/vm/isolate.h:409: void ClearPendingDeoptsAtOrBelow(uword fp) const;
This function is marked as const but it seems to modify pending_deopts_ how come
the compiler is not complaining.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages