Connecting UserClassifier to NtpSnippetsFetcher

components/ntp_snippets/remote/request_throttler.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_REMOTE_REQUEST_THROTTLER_H_
 #define COMPONENTS_NTP_SNIPPETS_REMOTE_REQUEST_THROTTLER_H_
 
 #include <string>
 
 #include "base/macros.h"
@@ skipping 22 matching lines @@
 // Implementation notes: When extending this class for a new RequestType, please
 //  1) define in request_counter.cc in kRequestTypeInfo
 //     a) the string value for your |type| and
 //     b) constants for day/count prefs;
 //  2) define a new RequestThrottlerTypes histogram suffix in histogram.xml
 //     (with the same string value as in 1a)).
 class RequestThrottler {
  public:
   // Enumeration listing all current applications of the request counter.
   enum class RequestType {
-    CONTENT_SUGGESTION_FETCHER,
+    CONTENT_SUGGESTION_FETCHER_RARE_NTP_USER,
+    CONTENT_SUGGESTION_FETCHER_ACTIVE_NTP_USER,
+    CONTENT_SUGGESTION_FETCHER_ACTIVE_SUGGESTIONS_CONSUMER,
     CONTENT_SUGGESTION_THUMBNAIL,
   };
 
   RequestThrottler(PrefService* pref_service, RequestType type);
 
+  void ChangeRequestType(RequestType new_type);

[Marc Treib, 2016/10/06 13:41:55]

Hm, I find this rather weird. Could we instead just create three separate
throttlers, one for each user class?

[jkrcal, 2016/10/06 14:45:58]

Okay (I would still like them to share the same pref values).

[Marc Treib, 2016/10/06 14:54:37]

Yup, sharing prefs makes sense.

+
   // Registers profile prefs for all RequestTypes. Called from browser_prefs.cc.
   static void RegisterProfilePrefs(PrefRegistrySimple* registry);
 
   // Returns whether quota is available for another request and reports this
   // information to UMA. Interactive requests should be always granted (upon
   // standard conditions) and should be only used for requests initiated by the
   // user (if it is safe to assume that all users cannot generate an amount of
   // requests we cannot handle).
   bool DemandQuotaForRequest(bool interactive_request);
 
@@ skipping 11 matching lines @@
   const char* GetRequestTypeName() const;
 
   int GetQuota(bool interactive_request) const;
   int GetCount(bool interactive_request) const;
   void SetCount(bool interactive_request, int count);
   int GetDay() const;
   void SetDay(int day);
   bool HasDay() const;
 
   PrefService* pref_service_;
-  const RequestTypeInfo& type_info_;
+  const RequestTypeInfo* type_info_;
 
   // The quotas are hardcoded, but can be overridden by variation params.
   int quota_;
   int interactive_quota_;
 
   // The histograms for reporting the requests of the given |type_|.
   base::HistogramBase* histogram_request_status_;
   base::HistogramBase* histogram_per_day_background_;
   base::HistogramBase* histogram_per_day_interactive_;
 
   DISALLOW_COPY_AND_ASSIGN(RequestThrottler);
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_REMOTE_REQUEST_THROTTLER_H_