Connecting UserClassifier to NtpSnippetsFetcher

components/ntp_snippets/remote/request_throttler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/remote/request_throttler.h"
 
 #include <climits>
+#include <set>
 #include <vector>
 
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/stringprintf.h"
 #include "base/time/time.h"
 #include "components/ntp_snippets/ntp_snippets_constants.h"
 #include "components/ntp_snippets/pref_names.h"
 #include "components/prefs/pref_registry_simple.h"
@@ skipping 25 matching lines @@
     const char* count_pref;
     const char* interactive_count_pref;
     const char* day_pref;
     const int default_quota;
     const int default_interactive_quota;
 };
 
 // When adding a new type here, extend also the "RequestThrottlerTypes"
 // <histogram_suffixes> in histograms.xml with the |name| string.
 const RequestThrottler::RequestTypeInfo RequestThrottler::kRequestTypeInfo[] = {
-    // RequestCounter::RequestType::CONTENT_SUGGESTION_FETCHER,
-    {"SuggestionFetcher", prefs::kSnippetFetcherRequestCount,
+    // The following three types share the same prefs. They differ in quota
+    // values (and UMA histograms).
+    // RequestCounter::RequestType::CONTENT_SUGGESTION_FETCHER_RARE_NTP_USER,
+    {"SuggestionFetcherRareNTPUser", prefs::kSnippetFetcherRequestCount,
      prefs::kSnippetFetcherInteractiveRequestCount,
-     prefs::kSnippetFetcherRequestsDay, 50, kUnlimitedQuota},
-     // RequestCounter::RequestType::CONTENT_SUGGESTION_THUMBNAIL,
+     prefs::kSnippetFetcherRequestsDay, 5, kUnlimitedQuota},
+    // RequestCounter::RequestType::CONTENT_SUGGESTION_FETCHER_ACTIVE_NTP_USER,
+    {"SuggestionFetcherActiveNTPUser", prefs::kSnippetFetcherRequestCount,
+     prefs::kSnippetFetcherInteractiveRequestCount,
+     prefs::kSnippetFetcherRequestsDay, 20, kUnlimitedQuota},
+    // RequestCounter::RequestType::CONTENT_SUGGESTION_FETCHER_ACTIVE_SUGGESTIONS_CONSUMER,
+    {"SuggestionFetcherActiveSuggestionsConsumer",
+     prefs::kSnippetFetcherRequestCount,
+     prefs::kSnippetFetcherInteractiveRequestCount,
+     prefs::kSnippetFetcherRequestsDay, 20, kUnlimitedQuota},
+    // RequestCounter::RequestType::CONTENT_SUGGESTION_THUMBNAIL,
     {"SuggestionThumbnailFetcher", prefs::kSnippetThumbnailsRequestCount,
      prefs::kSnippetThumbnailsInteractiveRequestCount,
      prefs::kSnippetThumbnailsRequestsDay, kUnlimitedQuota, kUnlimitedQuota}};
 
 RequestThrottler::RequestThrottler(PrefService* pref_service, RequestType type)
     : pref_service_(pref_service),
-      type_info_(kRequestTypeInfo[static_cast<int>(type)]) {
+      type_info_(nullptr) {
   DCHECK(pref_service);
+  ChangeRequestType(type);
+}
+
+void RequestThrottler::ChangeRequestType(RequestType new_type) {
+  // Do the changes only if the new type differs from the previous one.
+  if (type_info_ == &kRequestTypeInfo[static_cast<int>(new_type)])
+    return;
+
+  type_info_ = &kRequestTypeInfo[static_cast<int>(new_type)];
 
   std::string quota = variations::GetVariationParamValue(
       ntp_snippets::kStudyName,
       base::StringPrintf("quota_%s", GetRequestTypeName()));
   if (!base::StringToInt(quota, &quota_)) {
     LOG_IF(WARNING, !quota.empty())
         << "Invalid variation parameter for quota for "
         << GetRequestTypeName();
-    quota_ = type_info_.default_quota;
+    quota_ = type_info_->default_quota;
   }
 
   std::string interactive_quota = variations::GetVariationParamValue(
       ntp_snippets::kStudyName,
       base::StringPrintf("interactive_quota_%s", GetRequestTypeName()));
   if (!base::StringToInt(interactive_quota, &interactive_quota_)) {
     LOG_IF(WARNING, !interactive_quota.empty())
         << "Invalid variation parameter for interactive quota for "
         << GetRequestTypeName();
-    interactive_quota_ = type_info_.default_interactive_quota;
+    interactive_quota_ = type_info_->default_interactive_quota;
   }
 
   // Since the histogram names are dynamic, we cannot use the standard macros
   // and we need to lookup the histograms, instead.
   int status_count = static_cast<int>(RequestStatus::REQUEST_STATUS_COUNT);
   // Corresponds to UMA_HISTOGRAM_ENUMERATION(name, sample, |status_count|).
   histogram_request_status_ = base::LinearHistogram::FactoryGet(
       base::StringPrintf("NewTabPage.RequestThrottler.RequestStatus_%s",
                          GetRequestTypeName()),
       1, status_count, status_count + 1,
       base::HistogramBase::kUmaTargetedHistogramFlag);
   // Corresponds to UMA_HISTOGRAM_COUNTS_100(name, sample).
   histogram_per_day_background_ = base::Histogram::FactoryGet(
       base::StringPrintf("NewTabPage.RequestThrottler.PerDay_%s",
                          GetRequestTypeName()),
       1, 100, 50, base::HistogramBase::kUmaTargetedHistogramFlag);
   // Corresponds to UMA_HISTOGRAM_COUNTS_100(name, sample).
   histogram_per_day_interactive_ = base::Histogram::FactoryGet(
       base::StringPrintf("NewTabPage.RequestThrottler.PerDayInteractive_%s",
                          GetRequestTypeName()),
       1, 100, 50, base::HistogramBase::kUmaTargetedHistogramFlag);
 }
 
 // static
 void RequestThrottler::RegisterProfilePrefs(PrefRegistrySimple* registry) {
+  std::set<std::string> registered;
   for (const RequestTypeInfo& info : kRequestTypeInfo) {
+    // Make sure we do not register the same prefs twice. Assuming that if any
+    // types share some prefs, they share all the prefs. Thus, checking, e.g.,
+    // day_pref is enough.
+    if (registered.count(info.day_pref) > 0)
+      continue;
+
+    registered.insert(info.day_pref);
+    registry->RegisterIntegerPref(info.day_pref, 0);
     registry->RegisterIntegerPref(info.count_pref, 0);
     registry->RegisterIntegerPref(info.interactive_count_pref, 0);
-    registry->RegisterIntegerPref(info.day_pref, 0);
   }
 }
 
 bool RequestThrottler::DemandQuotaForRequest(bool interactive_request) {
   ResetCounterIfDayChanged();
 
   int new_count = GetCount(interactive_request) + 1;
   SetCount(interactive_request, new_count);
   bool available = (new_count <= GetQuota(interactive_request));
 
@@ skipping 21 matching lines @@
     histogram_per_day_background_->Add(GetCount(/*interactive_request=*/false));
     histogram_per_day_interactive_->Add(GetCount(/*interactive_request=*/true));
     // Reset the counters.
     SetCount(/*interactive_request=*/false, 0);
     SetCount(/*interactive_request=*/true, 0);
     SetDay(now_day);
   }
 }
 
 const char* RequestThrottler::GetRequestTypeName() const {
-  return type_info_.name;
+  return type_info_->name;
 }
 
 // TODO(jkrcal): turn RequestTypeInfo into a proper class, move those methods
 // onto the class and hide the members.
 int RequestThrottler::GetQuota(bool interactive_request) const {
   return interactive_request ? interactive_quota_ : quota_;
 }
 
 int RequestThrottler::GetCount(bool interactive_request) const {
   return pref_service_->GetInteger(interactive_request
-                                       ? type_info_.interactive_count_pref
-                                       : type_info_.count_pref);
+                                       ? type_info_->interactive_count_pref
+                                       : type_info_->count_pref);
 }
 
 void RequestThrottler::SetCount(bool interactive_request, int count) {
   pref_service_->SetInteger(interactive_request
-                                ? type_info_.interactive_count_pref
-                                : type_info_.count_pref,
+                                ? type_info_->interactive_count_pref
+                                : type_info_->count_pref,
                             count);
 }
 
 int RequestThrottler::GetDay() const {
-  return pref_service_->GetInteger(type_info_.day_pref);
+  return pref_service_->GetInteger(type_info_->day_pref);
 }
 
 void RequestThrottler::SetDay(int day) {
-  pref_service_->SetInteger(type_info_.day_pref, day);
+  pref_service_->SetInteger(type_info_->day_pref, day);
 }
 
 bool RequestThrottler::HasDay() const {
-  return pref_service_->HasPrefPath(type_info_.day_pref);
+  return pref_service_->HasPrefPath(type_info_->day_pref);
 }
 
 }  // namespace ntp_snippets