Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: components/ntp_snippets/remote/ntp_snippets_fetcher.cc

Issue 2395123002: Connecting UserClassifier to NtpSnippetsFetcher (Closed)
Patch Set: A small fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/remote/ntp_snippets_fetcher.h" 5 #include "components/ntp_snippets/remote/ntp_snippets_fetcher.h"
6 6
7 #include <cstdlib> 7 #include <cstdlib>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
11 #include "base/files/file_util.h" 11 #include "base/files/file_util.h"
12 #include "base/json/json_writer.h" 12 #include "base/json/json_writer.h"
13 #include "base/memory/ptr_util.h" 13 #include "base/memory/ptr_util.h"
14 #include "base/metrics/histogram_macros.h" 14 #include "base/metrics/histogram_macros.h"
15 #include "base/metrics/sparse_histogram.h" 15 #include "base/metrics/sparse_histogram.h"
16 #include "base/path_service.h" 16 #include "base/path_service.h"
17 #include "base/strings/string_number_conversions.h" 17 #include "base/strings/string_number_conversions.h"
18 #include "base/strings/string_util.h" 18 #include "base/strings/string_util.h"
19 #include "base/strings/stringprintf.h" 19 #include "base/strings/stringprintf.h"
20 #include "base/strings/utf_string_conversions.h" 20 #include "base/strings/utf_string_conversions.h"
21 #include "base/time/default_tick_clock.h" 21 #include "base/time/default_tick_clock.h"
22 #include "base/values.h" 22 #include "base/values.h"
23 #include "components/data_use_measurement/core/data_use_user_data.h" 23 #include "components/data_use_measurement/core/data_use_user_data.h"
24 #include "components/ntp_snippets/category_factory.h" 24 #include "components/ntp_snippets/category_factory.h"
25 #include "components/ntp_snippets/ntp_snippets_constants.h" 25 #include "components/ntp_snippets/ntp_snippets_constants.h"
26 #include "components/ntp_snippets/switches.h" 26 #include "components/ntp_snippets/switches.h"
27 #include "components/ntp_snippets/user_classifier.h"
27 #include "components/signin/core/browser/profile_oauth2_token_service.h" 28 #include "components/signin/core/browser/profile_oauth2_token_service.h"
28 #include "components/signin/core/browser/signin_manager.h" 29 #include "components/signin/core/browser/signin_manager.h"
29 #include "components/signin/core/browser/signin_manager_base.h" 30 #include "components/signin/core/browser/signin_manager_base.h"
30 #include "components/variations/net/variations_http_headers.h" 31 #include "components/variations/net/variations_http_headers.h"
31 #include "components/variations/variations_associated_data.h" 32 #include "components/variations/variations_associated_data.h"
32 #include "net/base/load_flags.h" 33 #include "net/base/load_flags.h"
33 #include "net/http/http_request_headers.h" 34 #include "net/http/http_request_headers.h"
34 #include "net/http/http_response_headers.h" 35 #include "net/http/http_response_headers.h"
35 #include "net/http/http_status_code.h" 36 #include "net/http/http_status_code.h"
36 #include "net/url_request/url_fetcher.h" 37 #include "net/url_request/url_fetcher.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 char locale[ULOC_FULLNAME_CAPACITY]; 167 char locale[ULOC_FULLNAME_CAPACITY];
167 UErrorCode error = U_ZERO_ERROR; 168 UErrorCode error = U_ZERO_ERROR;
168 // Translate the input to a posix locale. 169 // Translate the input to a posix locale.
169 uloc_forLanguageTag(language_code.c_str(), locale, ULOC_FULLNAME_CAPACITY, 170 uloc_forLanguageTag(language_code.c_str(), locale, ULOC_FULLNAME_CAPACITY,
170 nullptr, &error); 171 nullptr, &error);
171 DLOG_IF(WARNING, U_ZERO_ERROR != error) 172 DLOG_IF(WARNING, U_ZERO_ERROR != error)
172 << "Error in translating language code to a locale string: " << error; 173 << "Error in translating language code to a locale string: " << error;
173 return locale; 174 return locale;
174 } 175 }
175 176
177 RequestThrottler::RequestType GetRequestTypeForUserClass(
178 UserClassifier::UserClass user_class) {
179 switch (user_class) {
180 case UserClassifier::UserClass::RARE_NTP_USER:
181 return RequestThrottler::RequestType::
182 CONTENT_SUGGESTION_FETCHER_RARE_NTP_USER;
183 case UserClassifier::UserClass::ACTIVE_NTP_USER:
184 return RequestThrottler::RequestType::
185 CONTENT_SUGGESTION_FETCHER_ACTIVE_NTP_USER;
186 case UserClassifier::UserClass::ACTIVE_SUGGESTIONS_CONSUMER:
187 return RequestThrottler::RequestType::
188 CONTENT_SUGGESTION_FETCHER_ACTIVE_SUGGESTIONS_CONSUMER;
189 }
190 NOTREACHED();
191 return RequestThrottler::RequestType::
192 CONTENT_SUGGESTION_FETCHER_ACTIVE_NTP_USER;
193 }
194
176 } // namespace 195 } // namespace
177 196
178 NTPSnippetsFetcher::FetchedCategory::FetchedCategory(Category c) 197 NTPSnippetsFetcher::FetchedCategory::FetchedCategory(Category c)
179 : category(c) {} 198 : category(c) {}
180 199
181 NTPSnippetsFetcher::FetchedCategory::FetchedCategory(FetchedCategory&&) = 200 NTPSnippetsFetcher::FetchedCategory::FetchedCategory(FetchedCategory&&) =
182 default; 201 default;
183 NTPSnippetsFetcher::FetchedCategory::~FetchedCategory() = default; 202 NTPSnippetsFetcher::FetchedCategory::~FetchedCategory() = default;
184 NTPSnippetsFetcher::FetchedCategory& NTPSnippetsFetcher::FetchedCategory:: 203 NTPSnippetsFetcher::FetchedCategory& NTPSnippetsFetcher::FetchedCategory::
185 operator=(FetchedCategory&&) = default; 204 operator=(FetchedCategory&&) = default;
186 205
187 NTPSnippetsFetcher::NTPSnippetsFetcher( 206 NTPSnippetsFetcher::NTPSnippetsFetcher(
188 SigninManagerBase* signin_manager, 207 SigninManagerBase* signin_manager,
189 OAuth2TokenService* token_service, 208 OAuth2TokenService* token_service,
190 scoped_refptr<URLRequestContextGetter> url_request_context_getter, 209 scoped_refptr<URLRequestContextGetter> url_request_context_getter,
191 PrefService* pref_service, 210 PrefService* pref_service,
192 CategoryFactory* category_factory, 211 CategoryFactory* category_factory,
193 const ParseJSONCallback& parse_json_callback, 212 const ParseJSONCallback& parse_json_callback,
194 const std::string& api_key) 213 const std::string& api_key,
214 const UserClassifier* user_classifier)
195 : OAuth2TokenService::Consumer("ntp_snippets"), 215 : OAuth2TokenService::Consumer("ntp_snippets"),
196 signin_manager_(signin_manager), 216 signin_manager_(signin_manager),
197 token_service_(token_service), 217 token_service_(token_service),
198 waiting_for_refresh_token_(false), 218 waiting_for_refresh_token_(false),
199 url_request_context_getter_(std::move(url_request_context_getter)), 219 url_request_context_getter_(std::move(url_request_context_getter)),
200 category_factory_(category_factory), 220 category_factory_(category_factory),
201 parse_json_callback_(parse_json_callback), 221 parse_json_callback_(parse_json_callback),
202 count_to_fetch_(0), 222 count_to_fetch_(0),
203 fetch_url_(GetFetchEndpoint()), 223 fetch_url_(GetFetchEndpoint()),
204 fetch_api_(UsesChromeContentSuggestionsAPI(fetch_url_) 224 fetch_api_(UsesChromeContentSuggestionsAPI(fetch_url_)
205 ? CHROME_CONTENT_SUGGESTIONS_API 225 ? CHROME_CONTENT_SUGGESTIONS_API
206 : CHROME_READER_API), 226 : CHROME_READER_API),
207 api_key_(api_key), 227 api_key_(api_key),
208 interactive_request_(false), 228 interactive_request_(false),
209 tick_clock_(new base::DefaultTickClock()), 229 tick_clock_(new base::DefaultTickClock()),
230 user_classifier_(user_classifier),
210 request_throttler_( 231 request_throttler_(
211 pref_service, 232 pref_service,
212 RequestThrottler::RequestType::CONTENT_SUGGESTION_FETCHER), 233 GetRequestTypeForUserClass(user_classifier_->GetUserClass())),
213 oauth_token_retried_(false), 234 oauth_token_retried_(false),
214 weak_ptr_factory_(this) { 235 weak_ptr_factory_(this) {
215 // Parse the variation parameters and set the defaults if missing. 236 // Parse the variation parameters and set the defaults if missing.
216 std::string personalization = variations::GetVariationParamValue( 237 std::string personalization = variations::GetVariationParamValue(
217 ntp_snippets::kStudyName, kPersonalizationName); 238 ntp_snippets::kStudyName, kPersonalizationName);
218 if (personalization == kPersonalizationNonPersonalString) { 239 if (personalization == kPersonalizationNonPersonalString) {
219 personalization_ = Personalization::kNonPersonal; 240 personalization_ = Personalization::kNonPersonal;
220 } else if (personalization == kPersonalizationPersonalString) { 241 } else if (personalization == kPersonalizationPersonalString) {
221 personalization_ = Personalization::kPersonal; 242 personalization_ = Personalization::kPersonal;
222 } else { 243 } else {
(...skipping 26 matching lines...) Expand all
249 const SnippetsAvailableCallback& callback) { 270 const SnippetsAvailableCallback& callback) {
250 snippets_available_callback_ = callback; 271 snippets_available_callback_ = callback;
251 } 272 }
252 273
253 void NTPSnippetsFetcher::FetchSnippetsFromHosts( 274 void NTPSnippetsFetcher::FetchSnippetsFromHosts(
254 const std::set<std::string>& hosts, 275 const std::set<std::string>& hosts,
255 const std::string& language_code, 276 const std::string& language_code,
256 const std::set<std::string>& excluded_ids, 277 const std::set<std::string>& excluded_ids,
257 int count, 278 int count,
258 bool interactive_request) { 279 bool interactive_request) {
280 request_throttler_.ChangeRequestType(
281 GetRequestTypeForUserClass(user_classifier_->GetUserClass()));
259 if (!request_throttler_.DemandQuotaForRequest(interactive_request)) { 282 if (!request_throttler_.DemandQuotaForRequest(interactive_request)) {
260 FetchFinished(OptionalSnippets(), 283 FetchFinished(OptionalSnippets(),
261 interactive_request 284 interactive_request
262 ? FetchResult::INTERACTIVE_QUOTA_ERROR 285 ? FetchResult::INTERACTIVE_QUOTA_ERROR
263 : FetchResult::NON_INTERACTIVE_QUOTA_ERROR, 286 : FetchResult::NON_INTERACTIVE_QUOTA_ERROR,
264 /*extra_message=*/std::string()); 287 /*extra_message=*/std::string());
265 return; 288 return;
266 } 289 }
267 290
268 hosts_ = hosts; 291 hosts_ = hosts;
(...skipping 30 matching lines...) Expand all
299 } 322 }
300 } 323 }
301 324
302 NTPSnippetsFetcher::RequestParams::RequestParams() 325 NTPSnippetsFetcher::RequestParams::RequestParams()
303 : fetch_api(), 326 : fetch_api(),
304 obfuscated_gaia_id(), 327 obfuscated_gaia_id(),
305 only_return_personalized_results(), 328 only_return_personalized_results(),
306 user_locale(), 329 user_locale(),
307 host_restricts(), 330 host_restricts(),
308 count_to_fetch(), 331 count_to_fetch(),
309 interactive_request() {} 332 interactive_request(),
333 user_class() {}
310 334
311 NTPSnippetsFetcher::RequestParams::~RequestParams() = default; 335 NTPSnippetsFetcher::RequestParams::~RequestParams() = default;
312 336
313 std::string NTPSnippetsFetcher::RequestParams::BuildRequest() { 337 std::string NTPSnippetsFetcher::RequestParams::BuildRequest() {
314 auto request = base::MakeUnique<base::DictionaryValue>(); 338 auto request = base::MakeUnique<base::DictionaryValue>();
315 switch (fetch_api) { 339 switch (fetch_api) {
316 case CHROME_READER_API: { 340 case CHROME_READER_API: {
317 auto content_params = base::MakeUnique<base::DictionaryValue>(); 341 auto content_params = base::MakeUnique<base::DictionaryValue>();
318 content_params->SetBoolean("only_return_personalized_results", 342 content_params->SetBoolean("only_return_personalized_results",
319 only_return_personalized_results); 343 only_return_personalized_results);
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 ? "USER_ACTION" 398 ? "USER_ACTION"
375 : "BACKGROUND_PREFETCH"); 399 : "BACKGROUND_PREFETCH");
376 400
377 auto excluded = base::MakeUnique<base::ListValue>(); 401 auto excluded = base::MakeUnique<base::ListValue>();
378 for (const auto& id : excluded_ids) { 402 for (const auto& id : excluded_ids) {
379 excluded->AppendString(id); 403 excluded->AppendString(id);
380 if (excluded->GetSize() >= kMaxExcludedIds) 404 if (excluded->GetSize() >= kMaxExcludedIds)
381 break; 405 break;
382 } 406 }
383 request->Set("excludedSuggestionIds", std::move(excluded)); 407 request->Set("excludedSuggestionIds", std::move(excluded));
408 request->SetString("user_activeness_class", user_class);
384 409
385 // TODO(sfiera): support authentication and personalization 410 // TODO(sfiera): support authentication and personalization
386 // TODO(sfiera): support count_to_fetch 411 // TODO(sfiera): support count_to_fetch
387 break; 412 break;
388 } 413 }
389 } 414 }
390 415
391 std::string request_json; 416 std::string request_json;
392 bool success = base::JSONWriter::WriteWithOptions( 417 bool success = base::JSONWriter::WriteWithOptions(
393 *request, base::JSONWriter::OPTIONS_PRETTY_PRINT, &request_json); 418 *request, base::JSONWriter::OPTIONS_PRETTY_PRINT, &request_json);
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 fetch_url_.spec().c_str(), api_key_.c_str())); 471 fetch_url_.spec().c_str(), api_key_.c_str()));
447 472
448 RequestParams params; 473 RequestParams params;
449 params.fetch_api = fetch_api_; 474 params.fetch_api = fetch_api_;
450 params.host_restricts = 475 params.host_restricts =
451 UsesHostRestrictions() ? hosts_ : std::set<std::string>(); 476 UsesHostRestrictions() ? hosts_ : std::set<std::string>();
452 params.excluded_ids = excluded_ids_; 477 params.excluded_ids = excluded_ids_;
453 params.count_to_fetch = count_to_fetch_; 478 params.count_to_fetch = count_to_fetch_;
454 params.interactive_request = interactive_request_; 479 params.interactive_request = interactive_request_;
455 params.user_locale = locale_; 480 params.user_locale = locale_;
481 params.user_class = user_classifier_->GetUserClassNameForProto();
456 FetchSnippetsImpl(url, std::string(), params.BuildRequest()); 482 FetchSnippetsImpl(url, std::string(), params.BuildRequest());
457 } 483 }
458 484
459 void NTPSnippetsFetcher::FetchSnippetsAuthenticated( 485 void NTPSnippetsFetcher::FetchSnippetsAuthenticated(
460 const std::string& account_id, 486 const std::string& account_id,
461 const std::string& oauth_access_token) { 487 const std::string& oauth_access_token) {
462 RequestParams params; 488 RequestParams params;
463 params.fetch_api = fetch_api_; 489 params.fetch_api = fetch_api_;
464 params.obfuscated_gaia_id = account_id; 490 params.obfuscated_gaia_id = account_id;
465 params.only_return_personalized_results = 491 params.only_return_personalized_results =
466 personalization_ == Personalization::kPersonal; 492 personalization_ == Personalization::kPersonal;
467 params.user_locale = locale_; 493 params.user_locale = locale_;
468 params.host_restricts = 494 params.host_restricts =
469 UsesHostRestrictions() ? hosts_ : std::set<std::string>(); 495 UsesHostRestrictions() ? hosts_ : std::set<std::string>();
470 params.excluded_ids = excluded_ids_; 496 params.excluded_ids = excluded_ids_;
471 params.count_to_fetch = count_to_fetch_; 497 params.count_to_fetch = count_to_fetch_;
472 params.interactive_request = interactive_request_; 498 params.interactive_request = interactive_request_;
499 params.user_class = user_classifier_->GetUserClassNameForProto();
473 // TODO(jkrcal, treib): Add unit-tests for authenticated fetches. 500 // TODO(jkrcal, treib): Add unit-tests for authenticated fetches.
474 FetchSnippetsImpl(fetch_url_, 501 FetchSnippetsImpl(fetch_url_,
475 base::StringPrintf(kAuthorizationRequestHeaderFormat, 502 base::StringPrintf(kAuthorizationRequestHeaderFormat,
476 oauth_access_token.c_str()), 503 oauth_access_token.c_str()),
477 params.BuildRequest()); 504 params.BuildRequest());
478 } 505 }
479 506
480 void NTPSnippetsFetcher::StartTokenRequest() { 507 void NTPSnippetsFetcher::StartTokenRequest() {
481 OAuth2TokenService::ScopeSet scopes; 508 OAuth2TokenService::ScopeSet scopes;
482 scopes.insert(fetch_api_ == CHROME_CONTENT_SUGGESTIONS_API 509 scopes.insert(fetch_api_ == CHROME_CONTENT_SUGGESTIONS_API
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 UMA_HISTOGRAM_ENUMERATION("NewTabPage.Snippets.FetchResult", 691 UMA_HISTOGRAM_ENUMERATION("NewTabPage.Snippets.FetchResult",
665 static_cast<int>(result), 692 static_cast<int>(result),
666 static_cast<int>(FetchResult::RESULT_MAX)); 693 static_cast<int>(FetchResult::RESULT_MAX));
667 694
668 DVLOG(1) << "Fetch finished: " << last_status_; 695 DVLOG(1) << "Fetch finished: " << last_status_;
669 if (!snippets_available_callback_.is_null()) 696 if (!snippets_available_callback_.is_null())
670 snippets_available_callback_.Run(std::move(snippets)); 697 snippets_available_callback_.Run(std::move(snippets));
671 } 698 }
672 699
673 } // namespace ntp_snippets 700 } // namespace ntp_snippets
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698