Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2395113003: Ship Notification images (Closed)

Created:
4 years, 2 months ago by johnme
Modified:
4 years, 1 month ago
Reviewers:
chrishtr
CC:
awdf+watch_chromium.org, blink-reviews, chromium-reviews, darin-cc_chromium.org, haraken, jam, mlamouri+watch-notifications_chromium.org, Peter Beverloo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship Notification images Enables Notification images by default, instead of being behind the --enable-experimental-web-platform-features flag Intent to ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/y6U-3IGIduM/discussion BUG=614456 Committed: https://crrev.com/e46470fcbfad859c046e113258ae83780d60052b Cr-Commit-Position: refs/heads/master@{#432657}

Patch Set 1 #

Patch Set 2 : Rebase onto https://codereview.chromium.org/2507463003 #

Patch Set 3 : Re-uploading because UploadBaseFiles failed #

Patch Set 4 : Update platform/{win,linux}/virtual/stable/webexposed/global-interface-listing-expected.txt #

Patch Set 5 : Re-uploading because UploadBaseFiles timed out #

Messages

Total messages: 13 (9 generated)
johnme
I won't land until jochen's concern from https://groups.google.com/a/chromium.org/d/msg/blink-dev/y6U-3IGIduM/hrenH1IZBwAJ is addressed - following up on that ...
4 years, 2 months ago (2016-10-06 18:23:22 UTC) #3
chrishtr
lgtm
4 years, 2 months ago (2016-10-06 18:57:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395113003/80001
4 years, 1 month ago (2016-11-16 20:05:25 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 23:04:26 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e46470fcbfad859c046e113258ae83780d60052b
Cr-Commit-Position: refs/heads/master@{#432657}

Powered by Google App Engine
This is Rietveld 408576698