Use -[NSApp activateIgnoringOtherApps:NO] instead of -[NSRunningApplication activateWithOptions:].

Use -[NSApp activateIgnoringOtherApps:NO] instead of -[NSRunningApplication activateWithOptions:].

In c57771b074f8, +[BrowserWindowUtils activateWindowController:] was changed
from using Carbon's SetFrontProcessWithOptions(). This caused an activation bug,
https://crbug.com/653483, to occur. The difference in behavior is because the
NSApplication method internally calls _NXActivateSelf(), which uses
SetFrontProcessWithOptions(). The NSRunningApplication method instead messages
LaunchServices to set the front process.

The NSRunningApplication method appers to deactivate the app if it is currently
active, which caused the bug. Switching to the NSApplication method resolves
the issue and restores the old behavior. An alternatieve to using the
NSApplication method would be to make calling the NSRunningApplication method
conditional on -[NSApp isActive].

BUG=653483, 650845
R=avi@chromium.org

Committed: https://crrev.com/6d3dbe8eb6ff81ed2c9e89df2e13d1764056e9d7
Cr-Commit-Position: refs/heads/master@{#423590}

[Robert Sesek, 2016-10-06 16:44:05]

Description was changed from

==========
Use -[NSApp activateIgnoringOtherApps:NO] instead of -[NSRunningApplication
activateWithOptions:].

In c57771b074f8, +[BrowserWindowUtils activateWindowController:] was changed
from using Carbon's SetFrontProcessWithOptions. This caused an activation bug,
https://crbug.com/653483 to occur. The difference in behavior is because the
NSApplication method internally calls _NXActivateSelf(), which uses
SetFrontProcessWithOptions(). The NSRunningApplication method instead messages
LaunchServices to set the front process.

The NSRunningApplication method appers to deactivate the app if it is currently
active, which caused the bug. Switching to the NSApplication method resolves
the issue and restores the old behavior. An alternatieve to using the
NSApplication method would be to make calling the NSRunningApplication method
conditional on -[NSApp isActive].

BUG=653483,650845
R=avi@chromium.org
==========

to

==========
Use -[NSApp activateIgnoringOtherApps:NO] instead of -[NSRunningApplication
activateWithOptions:].

In c57771b074f8, +[BrowserWindowUtils activateWindowController:] was changed
from using Carbon's SetFrontProcessWithOptions(). This caused an activation bug,
https://crbug.com/653483 to occur. The difference in behavior is because the
NSApplication method internally calls _NXActivateSelf(), which uses
SetFrontProcessWithOptions(). The NSRunningApplication method instead messages
LaunchServices to set the front process.

The NSRunningApplication method appers to deactivate the app if it is currently
active, which caused the bug. Switching to the NSApplication method resolves
the issue and restores the old behavior. An alternatieve to using the
NSApplication method would be to make calling the NSRunningApplication method
conditional on -[NSApp isActive].

BUG=653483,650845
R=avi@chromium.org
==========

[Robert Sesek, 2016-10-06 16:44:40]

Description was changed from

==========
Use -[NSApp activateIgnoringOtherApps:NO] instead of -[NSRunningApplication
activateWithOptions:].

In c57771b074f8, +[BrowserWindowUtils activateWindowController:] was changed
from using Carbon's SetFrontProcessWithOptions(). This caused an activation bug,
https://crbug.com/653483 to occur. The difference in behavior is because the
NSApplication method internally calls _NXActivateSelf(), which uses
SetFrontProcessWithOptions(). The NSRunningApplication method instead messages
LaunchServices to set the front process.

The NSRunningApplication method appers to deactivate the app if it is currently
active, which caused the bug. Switching to the NSApplication method resolves
the issue and restores the old behavior. An alternatieve to using the
NSApplication method would be to make calling the NSRunningApplication method
conditional on -[NSApp isActive].

BUG=653483,650845
R=avi@chromium.org
==========

to

==========
Use -[NSApp activateIgnoringOtherApps:NO] instead of -[NSRunningApplication
activateWithOptions:].

In c57771b074f8, +[BrowserWindowUtils activateWindowController:] was changed
from using Carbon's SetFrontProcessWithOptions(). This caused an activation bug,
https://crbug.com/653483, to occur. The difference in behavior is because the
NSApplication method internally calls _NXActivateSelf(), which uses
SetFrontProcessWithOptions(). The NSRunningApplication method instead messages
LaunchServices to set the front process.

The NSRunningApplication method appers to deactivate the app if it is currently
active, which caused the bug. Switching to the NSApplication method resolves
the issue and restores the old behavior. An alternatieve to using the
NSApplication method would be to make calling the NSRunningApplication method
conditional on -[NSApp isActive].

BUG=653483,650845
R=avi@chromium.org
==========

[Robert Sesek, 2016-10-06 16:45:08]

The CQ bit was checked by rsesek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 16:45:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 17:15:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 17:15:44]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-10-06 18:07:58]

lgtm

[Robert Sesek, 2016-10-06 18:08:05]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2016-10-06 18:08:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 18:15:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-06 18:17:33]

Description was changed from

==========
Use -[NSApp activateIgnoringOtherApps:NO] instead of -[NSRunningApplication
activateWithOptions:].

In c57771b074f8, +[BrowserWindowUtils activateWindowController:] was changed
from using Carbon's SetFrontProcessWithOptions(). This caused an activation bug,
https://crbug.com/653483, to occur. The difference in behavior is because the
NSApplication method internally calls _NXActivateSelf(), which uses
SetFrontProcessWithOptions(). The NSRunningApplication method instead messages
LaunchServices to set the front process.

The NSRunningApplication method appers to deactivate the app if it is currently
active, which caused the bug. Switching to the NSApplication method resolves
the issue and restores the old behavior. An alternatieve to using the
NSApplication method would be to make calling the NSRunningApplication method
conditional on -[NSApp isActive].

BUG=653483,650845
R=avi@chromium.org
==========

to

==========
Use -[NSApp activateIgnoringOtherApps:NO] instead of -[NSRunningApplication
activateWithOptions:].

In c57771b074f8, +[BrowserWindowUtils activateWindowController:] was changed
from using Carbon's SetFrontProcessWithOptions(). This caused an activation bug,
https://crbug.com/653483, to occur. The difference in behavior is because the
NSApplication method internally calls _NXActivateSelf(), which uses
SetFrontProcessWithOptions(). The NSRunningApplication method instead messages
LaunchServices to set the front process.

The NSRunningApplication method appers to deactivate the app if it is currently
active, which caused the bug. Switching to the NSApplication method resolves
the issue and restores the old behavior. An alternatieve to using the
NSApplication method would be to make calling the NSRunningApplication method
conditional on -[NSApp isActive].

BUG=653483,650845
R=avi@chromium.org

Committed: https://crrev.com/6d3dbe8eb6ff81ed2c9e89df2e13d1764056e9d7
Cr-Commit-Position: refs/heads/master@{#423590}
==========

[commit-bot: I haz the power, 2016-10-06 18:17:34]

Patchset 1 (id:??) landed as
https://crrev.com/6d3dbe8eb6ff81ed2c9e89df2e13d1764056e9d7
Cr-Commit-Position: refs/heads/master@{#423590}