Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2395083002: [ignition] Inline the add for strings in AddWithFeedback (Closed)

Created:
4 years, 2 months ago by Leszek Swirski
Modified:
4 years, 2 months ago
Reviewers:
mythria, rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition] Inline the add for strings in AddWithFeedback There's no point going through all the checks in the Add stub when we already know that both sides are strings. Committed: https://crrev.com/c9b908a060e79912ae6fb787b113da5d497cfd90 Cr-Commit-Position: refs/heads/master@{#40047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M src/code-stubs.cc View 5 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Leszek Swirski
Follow up to the string feedback CL, with Mythri's suggested change. I don't see a ...
4 years, 2 months ago (2016-10-06 11:30:20 UTC) #6
rmcilroy
LGTM, thanks.
4 years, 2 months ago (2016-10-06 14:07:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395083002/1
4 years, 2 months ago (2016-10-06 14:40:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 15:13:44 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 15:14:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9b908a060e79912ae6fb787b113da5d497cfd90
Cr-Commit-Position: refs/heads/master@{#40047}

Powered by Google App Engine
This is Rietveld 408576698