Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2395073003: ValueSerializer: Check for no matching ArrayBufferView type being found. (Closed)

Created:
4 years, 2 months ago by jbroman
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ValueSerializer: Check for no matching ArrayBufferView type being found. Previously this would result in applying trying to find a size modulo zero, which causes SIGFPE. This approach was preferred over adding a default case to preserve the ability of the compiler to detect unhandled switch cases (within the valid range of the enum). BUG=chromium:148757 Committed: https://crrev.com/e4cc955780804a98425bc927742bd6a0907ea543 Cr-Commit-Position: refs/heads/master@{#40088}

Patch Set 1 #

Patch Set 2 : and a unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/value-serializer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jbroman
Also found with libfuzzer.
4 years, 2 months ago (2016-10-06 17:20:31 UTC) #8
Jakob Kummerow
lgtm
4 years, 2 months ago (2016-10-07 09:28:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395073003/20001
4 years, 2 months ago (2016-10-07 13:11:57 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 13:14:53 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 13:15:16 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e4cc955780804a98425bc927742bd6a0907ea543
Cr-Commit-Position: refs/heads/master@{#40088}

Powered by Google App Engine
This is Rietveld 408576698