Prune createVisibleSelectionDeprecated from SelectionAdjuster

Prune createVisibleSelectionDeprecated from SelectionAdjuster

BUG=651373
Committed: https://crrev.com/4b7a781809b93b15853be8f91db67f5c2584e0ad
Cr-Commit-Position: refs/heads/master@{#423465}

[Xiaocheng, 2016-10-06 02:54:17]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 02:54:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 04:10:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 04:10:09]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-10-06 04:37:26]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-10-06 04:37:27]

PTAL.

[yosin_UTC9, 2016-10-06 04:42:49]

https://codereview.chromium.org/2395053002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp (right):

https://codereview.chromium.org/2395053002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp:215:
base.document()->updateStyleAndLayoutIgnorePendingStylesheets();
There are only two places, one is test. So, could you hoist
updateStyleAndLayout... to call sites and put DCHECK for clean layout here?

[Xiaocheng, 2016-10-06 05:11:04]

https://codereview.chromium.org/2395053002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp (right):

https://codereview.chromium.org/2395053002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp:215:
base.document()->updateStyleAndLayoutIgnorePendingStylesheets();
On 2016/10/06 at 04:42:49, Yosi_UTC9 wrote:
> There are only two places, one is test. So, could you hoist
updateStyleAndLayout... to call sites and put DCHECK for clean layout here?

I could not... Last time (crrev.com/2389653002) the call site was hoisted to
FrameSelection::setSelectionAlgorithm, and then it caused a performance
regression (http://crbug.com/652301) and was reverted.

I don't think we can hoist it out of the |if|, as this is the only place
requiring clean layout during the execution of
SelectionEditor::setVisibleSelection (for both overloads).

Maybe I should add a note here about the regression.

[yosin_UTC9, 2016-10-06 05:18:06]

lgtm w/ nit: need to have TODO comment.

https://codereview.chromium.org/2395053002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp (right):

https://codereview.chromium.org/2395053002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp:215:
base.document()->updateStyleAndLayoutIgnorePendingStylesheets();
On 2016/10/06 at 05:11:04, Xiaocheng wrote:
> On 2016/10/06 at 04:42:49, Yosi_UTC9 wrote:
> > There are only two places, one is test. So, could you hoist
updateStyleAndLayout... to call sites and put DCHECK for clean layout here?
> 
> I could not... Last time (crrev.com/2389653002) the call site was hoisted to
FrameSelection::setSelectionAlgorithm, and then it caused a performance
regression (http://crbug.com/652301) and was reverted.
> 
> I don't think we can hoist it out of the |if|, as this is the only place
requiring clean layout during the execution of
SelectionEditor::setVisibleSelection (for both overloads).
> 
> Maybe I should add a note here about the regression.

I see, please add TODO(yosin) about regression. My lazy canoncalization should
fix this.

[Xiaocheng, 2016-10-06 05:45:30]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 05:45:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-10-06 05:46:04]

On 2016/10/06 at 05:18:06, yosin wrote:
> lgtm w/ nit: need to have TODO comment.
> 
>
https://codereview.chromium.org/2395053002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp (right):
> 
>
https://codereview.chromium.org/2395053002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp:215:
base.document()->updateStyleAndLayoutIgnorePendingStylesheets();
> On 2016/10/06 at 05:11:04, Xiaocheng wrote:
> > On 2016/10/06 at 04:42:49, Yosi_UTC9 wrote:
> > > There are only two places, one is test. So, could you hoist
updateStyleAndLayout... to call sites and put DCHECK for clean layout here?
> > 
> > I could not... Last time (crrev.com/2389653002) the call site was hoisted to
FrameSelection::setSelectionAlgorithm, and then it caused a performance
regression (http://crbug.com/652301) and was reverted.
> > 
> > I don't think we can hoist it out of the |if|, as this is the only place
requiring clean layout during the execution of
SelectionEditor::setVisibleSelection (for both overloads).
> > 
> > Maybe I should add a note here about the regression.
> 
> I see, please add TODO(yosin) about regression. My lazy canoncalization should
fix this.

Done.

[commit-bot: I haz the power, 2016-10-06 06:56:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 06:56:38]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-10-06 07:04:30]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-10-06 07:04:30]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2395053002/#ps20001
(title: "Add TODO about lazy VS validation")

[commit-bot: I haz the power, 2016-10-06 07:04:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 07:10:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 07:13:20]

Description was changed from

==========
Prune createVisibleSelectionDeprecated from SelectionAdjuster

BUG=651373
==========

to

==========
Prune createVisibleSelectionDeprecated from SelectionAdjuster

BUG=651373

Committed: https://crrev.com/4b7a781809b93b15853be8f91db67f5c2584e0ad
Cr-Commit-Position: refs/heads/master@{#423465}
==========

[commit-bot: I haz the power, 2016-10-06 07:13:21]

Patchset 2 (id:??) landed as
https://crrev.com/4b7a781809b93b15853be8f91db67f5c2584e0ad
Cr-Commit-Position: refs/heads/master@{#423465}