Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2395043002: Revert of Add Reclaim Support to ThreadLocalStorage (Closed)

Created:
4 years, 2 months ago by robliao
Modified:
4 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add Reclaim Support to ThreadLocalStorage (patchset #1 id:1 of https://codereview.chromium.org/2363783002/ ) Reason for revert: Precautionary revert while waiting for https://codereview.chromium.org/2383833004/ Will reland after branch point. Original issue's description: > Add Reclaim Support to ThreadLocalStorage > > Previously, ThreadLocalStorage::StaticSlot::Free() did not actually > release the corresponding ThreadLocalStorage slot. It simply cleared > out the slot and did not reuse it. As a result, each process had a > finite number of calls to ThreadLocalStorage::StaticSlot::Initialize() > before running out of slots. > > This problem would manifest itself in tests where a single process runs > many tests that each do their own initialization and uninitialization. > Tests that involve TLS usage caused the process to run out of TLS slots > because there was no free support in ThreadLocalStorage. > > This change adds in free support by doing what most operating systems > do, lock and track metadata in an array. > > BUG=590907 > > Committed: https://crrev.com/783d1f9630c86d816669ab23981d0f3722c96808 > Cr-Commit-Position: refs/heads/master@{#421320} TBR=brettw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=590907 Committed: https://crrev.com/75f2f7f6f9bdf3d851b5cc3914d32a3d0836c49d Cr-Commit-Position: refs/heads/master@{#423575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -100 lines) Patch
M base/threading/thread_local_storage.cc View 10 chunks +69 lines, -93 lines 0 comments Download
M base/threading/thread_local_storage_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
robliao
Created Revert of Add Reclaim Support to ThreadLocalStorage
4 years, 2 months ago (2016-10-06 02:08:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395043002/1
4 years, 2 months ago (2016-10-06 02:09:14 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/155149)
4 years, 2 months ago (2016-10-06 04:31:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395043002/1
4 years, 2 months ago (2016-10-06 17:05:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 17:37:49 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 17:40:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75f2f7f6f9bdf3d851b5cc3914d32a3d0836c49d
Cr-Commit-Position: refs/heads/master@{#423575}

Powered by Google App Engine
This is Rietveld 408576698