Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: src/parsing/expression-classifier.h

Issue 2395003002: Remove now-unused TailCallExpressionProduction from ExpressionClassifier (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/parsing/parser-base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/expression-classifier.h
diff --git a/src/parsing/expression-classifier.h b/src/parsing/expression-classifier.h
index 6a1fbac35a0c108b0da61473b42dca36a4f29ed5..d2dc6fa170406626b0ecdc411ca71f4c2e0dcf0d 100644
--- a/src/parsing/expression-classifier.h
+++ b/src/parsing/expression-classifier.h
@@ -22,8 +22,7 @@ class DuplicateFinder;
T(StrictModeFormalParametersProduction, 5) \
T(ArrowFormalParametersProduction, 6) \
T(LetPatternProduction, 7) \
- T(TailCallExpressionProduction, 8) \
- T(AsyncArrowFormalParametersProduction, 9)
+ T(AsyncArrowFormalParametersProduction, 8)
// Expression classifiers serve two purposes:
//
@@ -191,13 +190,6 @@ class ExpressionClassifier {
return reported_error(kLetPatternProduction);
}
- V8_INLINE bool has_tail_call_expression() const {
- return !is_valid(TailCallExpressionProduction);
- }
- V8_INLINE const Error& tail_call_expression_error() const {
- return reported_error(kTailCallExpressionProduction);
- }
-
V8_INLINE const Error& async_arrow_formal_parameters_error() const {
return reported_error(kAsyncArrowFormalParametersProduction);
}
@@ -299,14 +291,6 @@ class ExpressionClassifier {
Add(Error(loc, message, kLetPatternProduction, arg));
}
- void RecordTailCallExpressionError(const Scanner::Location& loc,
- MessageTemplate::Template message,
- const char* arg = nullptr) {
- if (has_tail_call_expression()) return;
- invalid_productions_ |= TailCallExpressionProduction;
- Add(Error(loc, message, kTailCallExpressionProduction, arg));
- }
-
void Accumulate(ExpressionClassifier* inner, unsigned productions,
bool merge_non_patterns = true) {
DCHECK_EQ(inner->reported_errors_, reported_errors_);
« no previous file with comments | « no previous file | src/parsing/parser-base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698