Patch for proper re-setting of frame selection's typing style.

Source/core/editing/DeleteSelectionCommand.cpp

 /*
  * Copyright (C) 2005 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 266 matching lines @@
 }
 
 void DeleteSelectionCommand::saveTypingStyleState()
 {
     // A common case is deleting characters that are all from the same text node. In
     // that case, the style at the start of the selection before deletion will be the
     // same as the style at the start of the selection after deletion (since those
     // two positions will be identical). Therefore there is no need to save the
     // typing style at the start of the selection, nor is there a reason to
     // compute the style at the start of the selection after deletion (see the
     // early return in calculateTypingStyleAfterDelete).

[yosin_UTC9, 2013/09/06 08:10:16]

We should update this comment.

-    if (m_upstreamStart.deprecatedNode() == m_downstreamEnd.deprecatedNode() && m_upstreamStart.deprecatedNode()->isTextNode())
+    if (m_upstreamStart.deprecatedNode() == m_downstreamEnd.deprecatedNode() && m_upstreamStart.deprecatedNode()->isTextNode()) {
+        document()->frame()->selection()->clearTypingStyle();

[yosin_UTC9, 2013/09/06 08:10:16]

nit: It seems you are working on old source code. Frame::selection() now returns
reference instead of pointer of FrameSelection.

[yosin_UTC9, 2013/09/06 08:10:16]

Should we call clearTypingStyle() in calculateTypingStyleAfterDelete()?

void DeleteSelectionCommand::calculateTypingStyleAfterDelete()
{
    if (!m_typingStyle) {
        document()->frame()->selection().clearTypingStyle();
        return;
    }
    ...
}

[arpitab_, 2013/09/06 14:01:32]

My bad! Have made the appropriate change in the new patch-set.

[arpitab_, 2013/09/06 14:01:32]

Yes! Although I don't see much difference between the two by way of
functionality. However, this seems more appropriate and in keeping with what we
do in Editor.cpp as well.
Have moved the clearTypingStyle() call to this place in patch-set 2.

         return;
+    }
 
     if (shouldNotInheritStyleFrom(*m_selectionToDelete.start().anchorNode()))
         return;
 
     // Figure out the typing style in effect before the delete is done.
     m_typingStyle = EditingStyle::create(m_selectionToDelete.start());
     m_typingStyle->removeStyleAddedByNode(enclosingAnchorElement(m_selectionToDelete.start()));
 
     // If we're deleting into a Mail blockquote, save the style at end() instead of start()
     // We'll use this later in computeTypingStyleAfterDelete if we end up outside of a Mail blockquote
@@ skipping 548 matching lines @@
 
 // Normally deletion doesn't preserve the typing style that was present before it.  For example,
 // type a character, Bold, then delete the character and start typing.  The Bold typing style shouldn't
 // stick around.  Deletion should preserve a typing style that *it* sets, however.
 bool DeleteSelectionCommand::preservesTypingStyle() const
 {
     return m_typingStyle;
 }
 
 } // namespace WebCore