LayoutTests/editing/deleting/maintain-style-after-delete.html - Issue 23950006: Patch for proper re-setting of frame selection's typing style.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/deleting/maintain-style-after-delete.html

Issue 23950006: Patch for proper re-setting of frame selection's typing style. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../../resources/dump-as-markup.js"></script>

	5 <div contenteditable="true">

	6 <div id="test">H <span style="color: blue;">W</span></div>
	yosin_UTC9 2013/09/06 08:10:16 Please add test case for multiple text nodes. tes Please add test case for multiple text nodes. testElement.appendChild(document.createTextNode("foo")); testElement.appendChild(document.createTextNode("bar")); Please caret between "foo" and "bar". This isn't true for m_upstreamStart.deprecatedNode() == m_downstreamEnd.deprecatedNode() && m_upstreamStart.deprecatedNode()->isTextNode(). arpitab_ 2013/09/06 14:01:32 Have added another test scenario (the second one) Show quoted text On 2013/09/06 08:10:16, Yoshifumi Inoue wrote: > Please add test case for multiple text nodes. > > testElement.appendChild(document.createTextNode("foo")); > testElement.appendChild(document.createTextNode("bar")); > > Please caret between "foo" and "bar". This isn't true for > m_upstreamStart.deprecatedNode() == m_downstreamEnd.deprecatedNode() && > m_upstreamStart.deprecatedNode()->isTextNode(). Have added another test scenario (the second one) in the added layout testcase which verifies the behavior for the scenario you have mentioned, i.e. to place the caret between the two text nodes and then type.
	7 </div>

	8 <script>

	9 Markup.description('Testcase for bug http://crbug.com/286219: When deleting edit able content, typing style should be reset when moving into another node.');

	10

	11 Markup.waitUntilDone();

	12

	13 var testElement = document.getElementById('test');

	14 var selection = window.getSelection();

	15

	16 selection.collapse(testElement, 2);

	17 document.execCommand("Delete");

	18 document.execCommand("InsertText", false, "O");

	19 Markup.dump(test);

	20

	21 document.execCommand("Delete");

	22 document.execCommand("Delete");

	23 document.execCommand("InsertText", false, "W");

	24 Markup.dump(test);

	25

	26 Markup.notifyDone();

	27 </script>

	28 </body>

	29 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/deleting/maintain-style-after-delete-expected.txt » ('j') | Source/core/editing/DeleteSelectionCommand.cpp » ('J')