Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2394983002: Throw a deserialization error internally in ValueDeserializer (previously-missed cases). (Closed)

Created:
4 years, 2 months ago by jbroman
Modified:
4 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Throw a deserialization error internally in ValueDeserializer (previously-missed cases). Caught with libfuzzer. BUG=chromium:148757 Committed: https://crrev.com/3a14fc91b90b94b02af8ecdcae20951e4848f6a8 Cr-Commit-Position: refs/heads/master@{#40046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/value-serializer.cc View 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jbroman
Just a few places I forgot to throw an exception when I made this code ...
4 years, 2 months ago (2016-10-05 22:01:22 UTC) #4
Jakob Kummerow
lgtm
4 years, 2 months ago (2016-10-06 11:35:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394983002/1
4 years, 2 months ago (2016-10-06 14:43:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 15:12:35 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 15:13:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a14fc91b90b94b02af8ecdcae20951e4848f6a8
Cr-Commit-Position: refs/heads/master@{#40046}

Powered by Google App Engine
This is Rietveld 408576698