Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2394973002:
[inspector] fix integer conversion (Closed)
Description[inspector] fix integer conversion
v8::Integer::Value() method returns int64 but all scriptIds are 32 bit based. We can safely cast int64 into int here to make compilers happy.
R=dgozman@chromium.org
Committed: https://crrev.com/6ea067a40c1f3c790c58227f28e9299eed91cf81
Cr-Commit-Position: refs/heads/master@{#40016}
Patch Set 1 #Patch Set 2 : a #
Messages
Total messages: 18 (12 generated)
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Dmitry, please take a look.
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
On 2016/10/05 22:41:38, dgozman wrote: > lgtm Please improve the description.
Description was changed from ========== [inspector] fix integer conversion R=dgozman@chromium.org ========== to ========== [inspector] fix integer conversion v8::Integer::Value() method returns int64 but all scriptIds are 32 bit based. We can safely cast int64 into int here to make compilers happy. R=dgozman@chromium.org ==========
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [inspector] fix integer conversion v8::Integer::Value() method returns int64 but all scriptIds are 32 bit based. We can safely cast int64 into int here to make compilers happy. R=dgozman@chromium.org ========== to ========== [inspector] fix integer conversion v8::Integer::Value() method returns int64 but all scriptIds are 32 bit based. We can safely cast int64 into int here to make compilers happy. R=dgozman@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [inspector] fix integer conversion v8::Integer::Value() method returns int64 but all scriptIds are 32 bit based. We can safely cast int64 into int here to make compilers happy. R=dgozman@chromium.org ========== to ========== [inspector] fix integer conversion v8::Integer::Value() method returns int64 but all scriptIds are 32 bit based. We can safely cast int64 into int here to make compilers happy. R=dgozman@chromium.org Committed: https://crrev.com/6ea067a40c1f3c790c58227f28e9299eed91cf81 Cr-Commit-Position: refs/heads/master@{#40016} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6ea067a40c1f3c790c58227f28e9299eed91cf81 Cr-Commit-Position: refs/heads/master@{#40016} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
