Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2394963002: MD Settings: Migrate site settings media-picker to native select. (Closed)

Created:
4 years, 2 months ago by dpapad
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Migrate site settings media-picker to native select. BUG=651513 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/53946c9e8a721709fbf419da6f944a6d40475067 Cr-Commit-Position: refs/heads/master@{#423345}

Patch Set 1 #

Patch Set 2 : Changing parent branch to not have to wait on other CLs. No diff change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M chrome/browser/resources/settings/site_settings/media_picker.html View 1 chunk +8 lines, -13 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/media_picker.js View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dpapad
Before/after screenshots: http://imgur.com/a/yPaZ5.
4 years, 2 months ago (2016-10-05 21:12:02 UTC) #5
Dan Beam
lgtm
4 years, 2 months ago (2016-10-05 21:33:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394963002/20001
4 years, 2 months ago (2016-10-05 21:41:04 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 23:59:31 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 00:02:28 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53946c9e8a721709fbf419da6f944a6d40475067
Cr-Commit-Position: refs/heads/master@{#423345}

Powered by Google App Engine
This is Rietveld 408576698