MD Settings: Migrating site_details_permission to native select.

chrome/test/data/webui/settings/site_details_permission_tests.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for site-details. */
 cr.define('site_details_permission', function() {
   function registerTests() {
     suite('SiteDetailsPermission', function() {
       /**
        * A site list element created before each test.
@@ skipping 52 matching lines @@
       // Tests that the given value is converted to the expected value, for a
       // given prefType.
       function isAllowed(origin, exceptionList) {
         for (var i = 0; i < exceptionList.length; ++i) {
           if (exceptionList[i].origin == origin)
             return exceptionList[i].setting == 'allow';
         }
         return false;
       };
 
-      function validatePermissionFlipWorks(origin, allow) {
-        MockInteractions.tap(allow ? testElement.$.allow : testElement.$.block);
+      function validatePermissionFlipWorks(origin, expectedPermissionValue) {

[dschuyler, 2016/10/05 22:23:17]

|expectedPermissionValue|, I like it!

[dpapad, 2016/10/05 22:41:47]

Done. I also merged 4 calls to
"browserProxy.resetResolver('setCategoryPermissionForOrigin');" to a single
call.

+        // Simulate permission change initiated by the user.
+        testElement.$.permission.value = expectedPermissionValue;
+        testElement.$.permission.dispatchEvent(new CustomEvent('change'));
+
         return browserProxy.whenCalled('setCategoryPermissionForOrigin').then(
-            function(arguments) {
-              assertEquals(origin, arguments[0]);
-              assertEquals('', arguments[1]);
-              assertEquals(testElement.category, arguments[2]);
-              assertEquals(allow ?
-                  settings.PermissionValues.ALLOW :
-                  settings.PermissionValues.BLOCK, arguments[3]);
+            function(args) {
+              assertEquals(origin, args[0]);
+              assertEquals('', args[1]);
+              assertEquals(testElement.category, args[2]);
+              assertEquals(expectedPermissionValue, args[3]);
             });
       };
 
       test('empty state', function() {
         browserProxy.setPrefs(prefsEmpty);
         testElement.category = settings.ContentSettingsTypes.CAMERA;
         testElement.site = {
           origin: 'http://www.google.com',
           embeddingOrigin: '',
         };
@@ skipping 14 matching lines @@
 
         return browserProxy.whenCalled('getExceptionList').then(function() {
           assertFalse(testElement.$.details.hidden);
 
           var header = testElement.$.details.querySelector(
               '#permissionHeader');
           assertEquals('Camera', header.innerText.trim(),
               'Widget should be labelled correctly');
 
           // Flip the permission and validate that prefs stay in sync.
-          return validatePermissionFlipWorks(origin, true);
+          return validatePermissionFlipWorks(
+              origin, settings.PermissionValues.ALLOW);
         }).then(function() {
           browserProxy.resetResolver('setCategoryPermissionForOrigin');
-          return validatePermissionFlipWorks(origin, false);
+          return validatePermissionFlipWorks(
+              origin, settings.PermissionValues.BLOCK);
         }).then(function() {
           browserProxy.resetResolver('setCategoryPermissionForOrigin');
-          return validatePermissionFlipWorks(origin, true);
+          return validatePermissionFlipWorks(
+              origin, settings.PermissionValues.ALLOW);
         });
       });
 
       test('cookies category', function() {
         var origin = "https://www.example.com";
         browserProxy.setPrefs(prefsCookies);
         testElement.category = settings.ContentSettingsTypes.COOKIES;
         testElement.site = {
           origin: origin,
           embeddingOrigin: '',
         };
 
         return browserProxy.whenCalled('getExceptionList').then(function() {
           assertFalse(testElement.$.details.hidden);
 
           var header = testElement.$.details.querySelector(
               '#permissionHeader');
           assertEquals('Cookies', header.innerText.trim(),
               'Widget should be labelled correctly');
 
-          MockInteractions.tap(testElement.$.sessionOnly);
-          return browserProxy.whenCalled('setCategoryPermissionForOrigin');
+          return validatePermissionFlipWorks(
+              origin, settings.PermissionValues.SESSION_ONLY);
         }).then(function(arguments) {

[dschuyler, 2016/10/05 22:23:17]

Let's remove the |arguments| arg (it's not used now).

-          assertEquals(origin, arguments[0]);
-          assertEquals('', arguments[1]);
-          assertEquals(testElement.category, arguments[2]);
-          assertEquals(settings.PermissionValues.SESSION_ONLY, arguments[3]);
           // Flip the permission and validate that prefs stay in sync.
           browserProxy.resetResolver('setCategoryPermissionForOrigin');
-          return validatePermissionFlipWorks(origin, true);
+          return validatePermissionFlipWorks(
+              origin, settings.PermissionValues.ALLOW);
         }).then(function() {
           browserProxy.resetResolver('setCategoryPermissionForOrigin');
-          return validatePermissionFlipWorks(origin, false);
+          return validatePermissionFlipWorks(
+              origin, settings.PermissionValues.BLOCK);
         });
       });
 
       test('disappear on empty', function() {
         var origin = "https://www.example.com";
         browserProxy.setPrefs(prefs);
         testElement.category = settings.ContentSettingsTypes.CAMERA;
         testElement.site = {
           origin: origin,
           embeddingOrigin: '',
         };
 
         return browserProxy.whenCalled('getExceptionList').then(function() {
           assertFalse(testElement.$.details.hidden);
 
           browserProxy.setPrefs(prefsEmpty);
           return browserProxy.whenCalled('getExceptionList');
         }).then(function() {
           assertTrue(testElement.$.details.hidden);
         });
       });
     });
   }
   return {
     registerTests: registerTests,
   };
 });