Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2394913003:
Fixed pos objects are offset from the top of the page in paged media (Closed)
DescriptionFixed pos objects are offset from the top of the page in paged media
BUG=652449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=eae@chromium.org
Committed: https://crrev.com/1784f2fdcda8d6ee356c82ddcbae096ab00113c3
Cr-Commit-Position: refs/heads/master@{#424572}
Patch Set 1 #Patch Set 2 : bug 652449 #
Total comments: 2
Patch Set 3 : bug 652449 #
Messages
Total messages: 30 (21 generated)
Description was changed from ========== Fixed pos objects are offset from the top of the page in paged media BUG=652449 ========== to ========== Fixed pos objects are offset from the top of the page in paged media BUG=652449 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by robhogan@gmail.com
The CQ bit was unchecked by robhogan@gmail.com
robhogan@gmail.com changed reviewers: + wangxianzhu@chromium.org
https://codereview.chromium.org/2394913003/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/printing/fixed-positioned-scrolled.html (right): https://codereview.chromium.org/2394913003/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/printing/fixed-positioned-scrolled.html:17: window.eventSender.keyDown("PageDown"); I think you can use window.scrollBy() to replace line 12-17. https://codereview.chromium.org/2394913003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right): https://codereview.chromium.org/2394913003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:590: // The fixed position object is offset from the top of the page, so remove any scroll offset. Nit: Wrap at 80 chars. (Though there are other comments exceeding 80 chars, some ones may be working on fixing them, so we should not introduce new ones.)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/10/06 at 22:40:42, wangxianzhu wrote: > https://codereview.chromium.org/2394913003/diff/20001/third_party/WebKit/Layo... > File third_party/WebKit/LayoutTests/printing/fixed-positioned-scrolled.html (right): > > https://codereview.chromium.org/2394913003/diff/20001/third_party/WebKit/Layo... > third_party/WebKit/LayoutTests/printing/fixed-positioned-scrolled.html:17: window.eventSender.keyDown("PageDown"); > I think you can use window.scrollBy() to replace line 12-17. > > https://codereview.chromium.org/2394913003/diff/20001/third_party/WebKit/Sour... > File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right): > > https://codereview.chromium.org/2394913003/diff/20001/third_party/WebKit/Sour... > third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:590: // The fixed position object is offset from the top of the page, so remove any scroll offset. > Nit: Wrap at 80 chars. (Though there are other comments exceeding 80 chars, some ones may be working on fixing them, so we should not introduce new ones.) Applied your comments - can you take another look?
The CQ bit was checked by wangxianzhu@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by robhogan@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fixed pos objects are offset from the top of the page in paged media BUG=652449 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Fixed pos objects are offset from the top of the page in paged media BUG=652449 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 TBR=eae@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fixed pos objects are offset from the top of the page in paged media BUG=652449 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 TBR=eae@chromium.org ========== to ========== Fixed pos objects are offset from the top of the page in paged media BUG=652449 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 TBR=eae@chromium.org Committed: https://crrev.com/1784f2fdcda8d6ee356c82ddcbae096ab00113c3 Cr-Commit-Position: refs/heads/master@{#424572} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1784f2fdcda8d6ee356c82ddcbae096ab00113c3 Cr-Commit-Position: refs/heads/master@{#424572} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
