Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 23949003: Check in expectations for all GM tests that don't have any yet, marked appropriately (Closed)

Created:
7 years, 3 months ago by epoger
Modified:
7 years, 3 months ago
Reviewers:
jvanverth1, borenet, reed1
CC:
skia-review_googlegroups.com, bsalomon, robertphillips, reed1, skiabot_google.com
Visibility:
Public.

Description

Check in expectations for all GM tests that don't have any yet, marked appropriately BUG=skia:1578 R=borenet@google.com, reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=11086

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+306576 lines, -13 lines) Patch
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 39 chunks +2340 lines, -0 lines 2 comments Download
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 38 chunks +2316 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json View 3 chunks +5785 lines, -1 line 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Release/expected-results.json View 3 chunks +5785 lines, -1 line 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 180 chunks +6096 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 180 chunks +6096 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json View 168 chunks +6420 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Release/expected-results.json View 168 chunks +6384 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json View 35 chunks +3228 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 35 chunks +3228 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json View 36 chunks +2256 lines, -0 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json View 36 chunks +2256 lines, -0 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json View 1 chunk +5942 lines, -1 line 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 1 chunk +5942 lines, -1 line 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json View 1 chunk +5942 lines, -1 line 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Release/expected-results.json View 1 chunk +5942 lines, -1 line 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Debug/expected-results.json View 1 chunk +5942 lines, -1 line 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Release/expected-results.json View 1 chunk +5942 lines, -1 line 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 167 chunks +7944 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 111 chunks +5976 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 167 chunks +7944 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 88 chunks +5616 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 167 chunks +7932 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 120 chunks +6048 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 167 chunks +7932 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 87 chunks +5580 lines, -0 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 chunk +14882 lines, -1 line 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +12974 lines, -1 line 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 chunk +14882 lines, -1 line 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 chunk +12578 lines, -1 line 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Debug/expected-results.json View 159 chunks +6528 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Release/expected-results.json View 159 chunks +6528 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Debug/expected-results.json View 159 chunks +6528 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release/expected-results.json View 159 chunks +6528 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-NoGPU-x86_64-Debug/expected-results.json View 157 chunks +5460 lines, -0 lines 0 comments Download
M expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 1 chunk +11930 lines, -1 line 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 167 chunks +12660 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json View 159 chunks +6612 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 159 chunks +6600 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 167 chunks +12660 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite/expected-results.json View 159 chunks +6612 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 159 chunks +6600 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 159 chunks +6600 lines, -0 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 159 chunks +6600 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epoger
https://codereview.chromium.org/23949003/diff/1/expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json File expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json (right): https://codereview.chromium.org/23949003/diff/1/expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json#newcode9 expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json:9: "3x3bitmaprect_565.png": { How I created this CL: 1. Make ...
7 years, 3 months ago (2013-09-04 17:36:29 UTC) #1
epoger
7 years, 3 months ago (2013-09-04 17:37:37 UTC) #2
reed1
98% lgtm
7 years, 3 months ago (2013-09-04 17:41:49 UTC) #3
borenet
LGTM
7 years, 3 months ago (2013-09-04 17:49:30 UTC) #4
jvanverth1
lgtm on the 2% Mike didn't look at.
7 years, 3 months ago (2013-09-04 17:57:17 UTC) #5
epoger
7 years, 3 months ago (2013-09-04 19:05:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r11086 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698