Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2394893002: [heap] Update verification of LO_SPACE in SizeOfInitialHeap (Closed)

Created:
4 years, 2 months ago by JaideepBajwa
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, JoranSiu, john.yan, michael_dawson, MTBrandyberry
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Update verification of LO_SPACE in SizeOfInitialHeap On PPC64 linux the OS page size is 64KB, therefore when the snapshot is created the serialized heap already has LO_SPACE allocated(the allocation goes beyond the 1st page of CODE_SPACE and hence LO_SPACE is allocated). I've updated the testcase to check if the delta of the LO_SPACE is zero. R=mlippautz@chromium.org, ulan@chromium.org, vogelheim@chromium.org BUG= Committed: https://crrev.com/45b64d15a0e95d11be29d24faff853a1ad03bfb3 Cr-Commit-Position: refs/heads/master@{#40014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M test/cctest/heap/test-spaces.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 2 months ago (2016-10-05 15:31:12 UTC) #1
Michael Lippautz
lgtm
4 years, 2 months ago (2016-10-05 18:41:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394893002/1
4 years, 2 months ago (2016-10-05 18:57:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 19:47:18 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 19:47:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45b64d15a0e95d11be29d24faff853a1ad03bfb3
Cr-Commit-Position: refs/heads/master@{#40014}

Powered by Google App Engine
This is Rietveld 408576698