Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2394883004: Fix compile error on simple chrome. (Closed)

Created:
4 years, 2 months ago by hidehiko
Modified:
4 years, 2 months ago
Reviewers:
kinaba
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org, Luis Héctor Chávez
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compile error on simple chrome. Under C++11, NVRO can happen when a return's expression has the function's return type. Here, those are different (although FakeArcBridgeBootstrap inherits ArcBridgeBootstrap), thus explicit std::move() should be here. Note, C++17 or later, the condition is relaxed and NVRO becomes mandatory, so the old code should work, though. cf): C++11 n3337/12.8/32, C++17 n4594/12.8/32 BUG=633258 TEST=Ran bots. Build component_unittests under simple chrome env. Committed: https://crrev.com/778baa7c83b7c45eee055f53ac445cdeba5cfbdd Cr-Commit-Position: refs/heads/master@{#423436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/arc/arc_bridge_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
hidehiko
PTAL.
4 years, 2 months ago (2016-10-06 02:18:04 UTC) #4
kinaba
lgtm
4 years, 2 months ago (2016-10-06 02:19:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394883004/1
4 years, 2 months ago (2016-10-06 05:04:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 05:09:38 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 05:11:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/778baa7c83b7c45eee055f53ac445cdeba5cfbdd
Cr-Commit-Position: refs/heads/master@{#423436}

Powered by Google App Engine
This is Rietveld 408576698