Enable OPUS and VP9 codecs on Android for Clear Key key system

Enable OPUS and VP9 codecs on Android for Clear Key key system

Code in MimeUtil::IsCodecSupportedOnPlatform() now does the correct
check to determine if OPUS or VP9 is supported on the platform, so
the old code that disabled those codecs on Android is no longer needed.

BUG=652896
Committed: https://crrev.com/7b3840dcaad1e52f50053230327259eeb26eba89
Cr-Commit-Position: refs/heads/master@{#423428}

[jrummell, 2016-10-05 22:29:47]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, xhwang@chromium.org

[jrummell, 2016-10-05 22:29:48]

PTAL

[ddorwin, 2016-10-05 22:44:01]

Description nits:
* Please make it clear that this corrects the behavior by removing code that is
no longer necessary since we have real checks in mime_util. Fixing the test is a
byproduct (although the reason we discovered this).
* Please use "Clear Key".

LGTM

[jrummell, 2016-10-06 00:02:27]

Description was changed from

==========
Enable OPUS and VP9 codecs on Android for ClearKey key system

Code in MimeUtil::IsCodecSupportedOnPlatform() now does a proper
check to determine if OPUS or VP9 is supported on the platform, so
let ClearKey appear to support it.

BUG=652896
==========

to

==========
Enable OPUS and VP9 codecs on Android for Clear Key key system

Code in MimeUtil::IsCodecSupportedOnPlatform() now does the correct
check to determine if OPUS or VP9 is supported on the platform, so
the old code that disabled those codecs on Android is no longer needed.

BUG=652896
==========

[jrummell, 2016-10-06 00:03:06]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2016-10-06 00:03:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 02:55:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 02:55:24]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ddorwin, 2016-10-06 03:00:50]

The CQ bit was checked by ddorwin@chromium.org

[commit-bot: I haz the power, 2016-10-06 03:01:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 04:16:07]

Description was changed from

==========
Enable OPUS and VP9 codecs on Android for Clear Key key system

Code in MimeUtil::IsCodecSupportedOnPlatform() now does the correct
check to determine if OPUS or VP9 is supported on the platform, so
the old code that disabled those codecs on Android is no longer needed.

BUG=652896
==========

to

==========
Enable OPUS and VP9 codecs on Android for Clear Key key system

Code in MimeUtil::IsCodecSupportedOnPlatform() now does the correct
check to determine if OPUS or VP9 is supported on the platform, so
the old code that disabled those codecs on Android is no longer needed.

BUG=652896
==========

[commit-bot: I haz the power, 2016-10-06 04:16:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-06 04:18:12]

Description was changed from

==========
Enable OPUS and VP9 codecs on Android for Clear Key key system

Code in MimeUtil::IsCodecSupportedOnPlatform() now does the correct
check to determine if OPUS or VP9 is supported on the platform, so
the old code that disabled those codecs on Android is no longer needed.

BUG=652896
==========

to

==========
Enable OPUS and VP9 codecs on Android for Clear Key key system

Code in MimeUtil::IsCodecSupportedOnPlatform() now does the correct
check to determine if OPUS or VP9 is supported on the platform, so
the old code that disabled those codecs on Android is no longer needed.

BUG=652896

Committed: https://crrev.com/7b3840dcaad1e52f50053230327259eeb26eba89
Cr-Commit-Position: refs/heads/master@{#423428}
==========

[commit-bot: I haz the power, 2016-10-06 04:18:13]

Patchset 1 (id:??) landed as
https://crrev.com/7b3840dcaad1e52f50053230327259eeb26eba89
Cr-Commit-Position: refs/heads/master@{#423428}

[xhwang, 2016-10-07 07:08:00]

This also fixes https://bugs.chromium.org/p/chromium/issues/detail?id=586629

[xhwang, 2016-10-07 07:21:26]

On 2016/10/07 07:08:00, xhwang wrote:
> This also fixes https://bugs.chromium.org/p/chromium/issues/detail?id=586629

Quick question, where do we check MimeUtil::IsCodecSupportedOnPlatform() to
check whether we support vp9? If it because of this comment?

https://cs.chromium.org/chromium/src/media/base/mime_util_internal.cc?rcl=0&l...

Also, what if we have kReportVp9AsAnUnsupportedMimeType specified? Maybe we
don't care?

https://cs.chromium.org/chromium/src/media/base/mime_util_internal.cc?rcl=0&l...