Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2394873003: [Mojo] Make javascript enums extensible. (Closed)

Created:
4 years, 2 months ago by mbjorge
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mojo] Make javascript enums extensible. BUG=581390 TEST=mojo_js_unittests, mojo_js_integration_tests Original review at: https://codereview.chromium.org/2380303003/ Committed: https://crrev.com/3c19074450571b0fdd16063353e726cbe07c8dcc Cr-Commit-Position: refs/heads/master@{#423302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -12 lines) Patch
M mojo/public/js/codec.js View 2 chunks +15 lines, -0 lines 0 comments Download
M mojo/public/js/validation_unittests.js View 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/public/js/validator.js View 3 chunks +14 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/enum_definition.tmpl View 1 chunk +26 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/validation_macros.tmpl View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 7 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mbjorge
I don't know what I did to my local checkout, but I goof'd something up ...
4 years, 2 months ago (2016-10-05 18:55:06 UTC) #3
Ken Rockot(use gerrit already)
LGTM, but I've never seen that happen so there might actually be something subtle wrong ...
4 years, 2 months ago (2016-10-05 20:42:43 UTC) #6
Ken Rockot(use gerrit already)
On 2016/10/05 at 20:42:43, Ken Rockot wrote: > LGTM, but I've never seen that happen ...
4 years, 2 months ago (2016-10-05 20:49:12 UTC) #7
mbjorge
On 2016/10/05 at 20:42:43, rockot wrote: > LGTM, but I've never seen that happen so ...
4 years, 2 months ago (2016-10-05 20:51:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394873003/1
4 years, 2 months ago (2016-10-05 20:52:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 21:45:34 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 21:47:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c19074450571b0fdd16063353e726cbe07c8dcc
Cr-Commit-Position: refs/heads/master@{#423302}

Powered by Google App Engine
This is Rietveld 408576698