Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2394873002: [ic] Avoid feedback metadata names table reallocations. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Avoid feedback metadata names table reallocations. An attempt to fix memory regression (r38047) caused another regression because custom capacity chosen for names dictionary implied reallocations during initialization in some cases. BUG=chromium:625894, chromium:632231 Committed: https://crrev.com/c56222c9bd279c8a94697e21ed8ce1e0813c6347 Cr-Commit-Position: refs/heads/master@{#40006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/type-feedback-vector.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Igor Sheludko
PTAL
4 years, 2 months ago (2016-10-05 15:15:10 UTC) #5
Jakob Kummerow
lgtm
4 years, 2 months ago (2016-10-05 17:34:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394873002/20001
4 years, 2 months ago (2016-10-05 17:34:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-05 17:55:29 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 17:55:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c56222c9bd279c8a94697e21ed8ce1e0813c6347
Cr-Commit-Position: refs/heads/master@{#40006}

Powered by Google App Engine
This is Rietveld 408576698