Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2394843003: Fix iOS surface creation for SampleApp (Closed)

Created:
4 years, 2 months ago by jvanverth1
Modified:
4 years, 2 months ago
Reviewers:
Brian Osman, bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -42 lines) Patch
M experimental/iOSSampleApp/SkSampleUIView.mm View 8 chunks +40 lines, -37 lines 0 comments Download
M include/views/SkWindow.h View 2 chunks +5 lines, -5 lines 0 comments Download
M samplecode/SampleApp.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jvanverth1
4 years, 2 months ago (2016-10-05 13:42:36 UTC) #3
Brian Osman
lgtm
4 years, 2 months ago (2016-10-09 19:19:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394843003/1
4 years, 2 months ago (2016-10-10 13:20:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/14647)
4 years, 2 months ago (2016-10-10 13:22:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394843003/1
4 years, 2 months ago (2016-10-10 14:38:43 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 14:39:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/38c72151576a6e89b31b0bd4c45a0b01c11641ff

Powered by Google App Engine
This is Rietveld 408576698