Resource: helper class to prohibit {add,remove}Client() calls in scope

third_party/WebKit/Source/core/fetch/ResourceTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/fetch/Resource.h"
 
 #include "core/fetch/MemoryCache.h"
+#include "core/fetch/MockResourceClients.h"
 #include "core/fetch/RawResource.h"
 #include "platform/SharedBuffer.h"
 #include "platform/network/ResourceRequest.h"
 #include "platform/network/ResourceResponse.h"
 #include "platform/testing/TestingPlatformSupport.h"
 #include "platform/testing/URLTestHelpers.h"
 #include "public/platform/Platform.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "wtf/Vector.h"
 
@@ skipping 27 matching lines @@
 void createTestResourceAndSetCachedMetadata(const ResourceResponse& response) {
   const char testData[] = "test data";
   Resource* resource =
       RawResource::create(ResourceRequest(response.url()), Resource::Raw);
   resource->setResponse(response);
   resource->cacheHandler()->setCachedMetadata(
       100, testData, sizeof(testData), CachedMetadataHandler::SendToPlatform);
   return;
 }
 
+class TestProhibitAddRemoveClientResource final : public Resource {
+ public:
+  static TestProhibitAddRemoveClientResource* create() {
+    return new TestProhibitAddRemoveClientResource();
+  }
+  void testAddClient(ResourceClient* client) {
+    ProhibitAddRemoveClientInScope prohibitAddRemoveClient(this);
+    addClient(client);
+  }
+  void testRemoveClient(ResourceClient* client) {
+    ProhibitAddRemoveClientInScope prohibitAddRemoveClient(this);
+    removeClient(client);
+  }
+
+ private:
+  TestProhibitAddRemoveClientResource()
+      : Resource(ResourceRequest(), Resource::Raw, ResourceLoaderOptions()) {}
+};
+
 }  // anonymous namespace
 
 TEST(ResourceTest, SetCachedMetadata_SendsMetadataToPlatform) {
   MockPlatform mock;
   ResourceResponse response(createTestResourceResponse());
   createTestResourceAndSetCachedMetadata(response);
   EXPECT_EQ(1u, mock.cachedURLs().size());
 }
 
 TEST(
@@ skipping 18 matching lines @@
   // Revalidating with a url that differs by only the fragment
   // shouldn't trigger a securiy check.
   url.setFragmentIdentifier("bar");
   resource->setRevalidatingRequest(ResourceRequest(url));
   ResourceResponse revalidatingResponse;
   revalidatingResponse.setURL(url);
   revalidatingResponse.setHTTPStatusCode(304);
   resource->responseReceived(revalidatingResponse, nullptr);
 }
 
+TEST(ResourceTest, ProhibitAddRemoveClientInScope) {
+  TestProhibitAddRemoveClientResource* resource =
+      TestProhibitAddRemoveClientResource::create();
+  Persistent<MockResourceClient> client = new MockResourceClient();
+  EXPECT_DEATH(resource->testAddClient(client),
+               "!m_isAddRemoveClientProhibited");
+  resource->addClient(client);
+  EXPECT_DEATH(resource->testRemoveClient(client),
+               "!m_isAddRemoveClientProhibited");
+}
+
 }  // namespace blink