Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2394783002: [turbofan] Properly specialize JSCreateIterResultObject map. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly specialize JSCreateIterResultObject map. If possible, take the constant map from the (known) native context for JSCreateIterResultObject, so that subsequent map checks can be eliminated in case of iterator inlining. R=jarin@chromium.org BUG=v8:3822 Committed: https://crrev.com/50c458a389d3f3878c72adc085f1e0caceb51ac6 Cr-Commit-Position: refs/heads/master@{#39974}

Patch Set 1 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
M src/compiler/js-create-lowering.h View 3 chunks +5 lines, -1 line 0 comments Download
M src/compiler/js-create-lowering.cc View 2 chunks +24 lines, -8 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-create-lowering-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-05 05:33:39 UTC) #1
Benedikt Meurer
Hey Jaro, A simple change to eliminate redundant map checks for the iterator results in ...
4 years, 2 months ago (2016-10-05 05:36:05 UTC) #4
Jarin
lgtm
4 years, 2 months ago (2016-10-05 05:53:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394783002/20001
4 years, 2 months ago (2016-10-05 05:54:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-05 06:32:08 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 06:32:26 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50c458a389d3f3878c72adc085f1e0caceb51ac6
Cr-Commit-Position: refs/heads/master@{#39974}

Powered by Google App Engine
This is Rietveld 408576698